Pierre Schweitzer : msi: Don't leak memory on failure.

Alexandre Julliard julliard at winehq.org
Tue Oct 24 02:40:04 CDT 2017


Module: wine
Branch: master
Commit: a6ad46dc940d1da4f567156e306c2349641c8437
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a6ad46dc940d1da4f567156e306c2349641c8437

Author: Pierre Schweitzer <pierre at reactos.org>
Date:   Sat Oct 21 11:48:30 2017 +0200

msi: Don't leak memory on failure.

Signed-off-by: Pierre Schweitzer <pierre at reactos.org>
Signed-off-by: Hans Leidekker <hans at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/msi/package.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/msi/package.c b/dlls/msi/package.c
index 18466e1..2f6027b 100644
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -2286,7 +2286,10 @@ static MSIRECORD *msi_get_property_row( MSIDATABASE *db, LPCWSTR name )
 
         row = MSI_CreateRecord(1);
         if (!row)
+        {
+            msi_free(buffer);
             return NULL;
+        }
         MSI_RecordSetStringW(row, 1, buffer);
         msi_free(buffer);
         return row;
@@ -2301,7 +2304,10 @@ static MSIRECORD *msi_get_property_row( MSIDATABASE *db, LPCWSTR name )
 
         row = MSI_CreateRecord(1);
         if (!row)
+        {
+            msi_free(buffer);
             return NULL;
+        }
         MSI_RecordSetStringW(row, 1, buffer);
         msi_free(buffer);
         return row;




More information about the wine-cvs mailing list