Rosanne DiMesio : Fix Extra comments field

Jeremy Newman jnewman at winehq.org
Fri Sep 22 14:24:24 CDT 2017


Module: appdb
Branch: master
Commit: 2bc14bd60f0a804e10a98e2f3c2fc38619c7d503
URL:    http://source.winehq.org/git/appdb.git/?a=commit;h=2bc14bd60f0a804e10a98e2f3c2fc38619c7d503

Author: Rosanne DiMesio <dimesio at earthlink.net>
Date:   Fri Sep 22 11:48:26 2017 -0500

Fix Extra comments field

Fixes bug 43755. Also fixes a typo in the Hardware section.

Signed-off-by: Rosanne DiMesio <dimesio at earthlink.net>
Signed-off-by: Jeremy Newman <jnewman at codeweavers.com>

---

 include/testData.php | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/include/testData.php b/include/testData.php
index 86771d2..baf69f3 100644
--- a/include/testData.php
+++ b/include/testData.php
@@ -21,7 +21,7 @@ class testData{
     var $sUsedWorkaround;
     var $shWorkarounds;
     var $sTestedRating;
-    var $sComments;
+    var $shComments;
     var $sSubmitTime;
     var $iSubmitterId;
     var $sGpuMfr;
@@ -61,7 +61,7 @@ class testData{
             $this->sUsedWorkaround = $oRow->usedWorkaround;
             $this->shWorkarounds = $oRow->workarounds;
             $this->sTestedRating = $oRow->testedRating;
-            $this->sComments = $oRow->comments;
+            $this->shComments = $oRow->comments;
             $this->sSubmitTime = $oRow->submitTime;
             $this->iSubmitterId = $oRow->submitterId;
             $this->sState = $oRow->state;
@@ -102,7 +102,7 @@ class testData{
                                     $this->sUsedWorkaround,
                                     $this->shWorkarounds,
                                     $this->sTestedRating, 
-                                    $this->sComments,
+                                    $this->shComments,
                                     date("Y-m-d H:i:s"),
                                     $_SESSION['current']->iUserId,
                                     $this->sState,
@@ -176,10 +176,10 @@ class testData{
                     $oOldTest->shWhatNotTested."'\nto\n'$this->shWhatNotTested'.\n";
         }
 
-        if($this->sComments != $oOldTest->sComments)
+        if($this->shComments != $oOldTest->shComments)
         {
             $sWhatChanged .= "Extra comments was changed from\n'".
-                    $oOldTest->sComments."'\nto\n'$this->sComments'.\n";
+                    $oOldTest->shComments."'\nto\n'$this->shComments'.\n";
         }
 
         if($this->iDistributionId != $oOldTest->iDistributionId)
@@ -271,7 +271,7 @@ class testData{
                             $this->sUsedWorkaround,
                             $this->shWorkarounds,
                             $this->sTestedRating,
-                            $this->sComments,
+                            $this->shComments,
                             $this->sState,
                             $this->sGpuMfr,
                             $this->sGraphicsDriver,
@@ -583,8 +583,8 @@ class testData{
                "<p><b>What does not</b></p>\n<p>{$this->shWhatDoesnt}</p>\n".
                "<p><b>Workarounds</b></p>\n<p>{$this->shWorkarounds}</p>\n".               
                "<p><b>What was not tested</b></p>\n<p>{$this->shWhatNotTested}</p>\n".
-               "<p><b>Hardware tested</b></p>\n<p><i>Graphics: </i></ul><li>GPU: {$this->sGpuMfr}</li><li>Driver: {$this->sGraphicsDriver}</li></ul></p>".
-               "<p><b>Additional Comments</b></p>\n<p>{$this->sComments}</p>\n";
+               "<p><b>Hardware tested</b></p>\n<p><i>Graphics: </i><ul><li>GPU: {$this->sGpuMfr}</li><li>Driver: {$this->sGraphicsDriver}</li></ul></p>".
+               "<p><b>Additional Comments</b></p>\n<p>{$this->shComments}</p>\n";
     }
 
     function CreateTestTable()
@@ -907,8 +907,8 @@ class testData{
         echo '<a href="https://wiki.winehq.org/AppDB_Maintainer_Rating_Definitions" target="_blank">Rating definitions</a></td></tr>',"\n";
         // extra comments
         echo '<tr valign=top><td><b>Extra comments</b></td>',"\n";
-        echo '<td><textarea name="sComments" id="extra_comments" rows=20 cols=80 class="wysiwyg">';
-        echo $this->sComments.'</textarea></td></tr>',"\n";
+        echo '<td><textarea name="shComments" id="extra_comments" rows=20 cols=80 class="wysiwyg">';
+        echo $this->shComments.'</textarea></td></tr>',"\n";
 
         /* Graphics hardware/driver
             this section could be expanded to include info on other hardware (e.g., CPU, audio) */
@@ -1100,7 +1100,7 @@ class testData{
         $this->sRuns = $aValues['sRuns'];
         $this->sUsedWorkaround = $aValues['sUsedWorkaround'];
         $this->sTestedRating = $aValues['sTestedRating'];
-        $this->sComments = $aValues['sComments'];
+        $this->shComments = $aValues['shComments'];
         $this->sGpuMfr = $aValues['sGpuMfr'];
         $this->sGraphicsDriver = $aValues['sGraphicsDriver'];
     }




More information about the wine-cvs mailing list