Nikolay Sivov : shell32: Added missing arguments to trace messages.

Alexandre Julliard julliard at winehq.org
Thu Sep 28 18:36:35 CDT 2017


Module: wine
Branch: master
Commit: c36e7d1ec7537999f7c7cba610bbbcefd5d9d6eb
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c36e7d1ec7537999f7c7cba610bbbcefd5d9d6eb

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Sep 28 11:25:47 2017 +0300

shell32: Added missing arguments to trace messages.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/shell32/shelldispatch.c | 40 ++++++++++++++++++----------------------
 1 file changed, 18 insertions(+), 22 deletions(-)

diff --git a/dlls/shell32/shelldispatch.c b/dlls/shell32/shelldispatch.c
index 82fc9ac..0baab6b 100644
--- a/dlls/shell32/shelldispatch.c
+++ b/dlls/shell32/shelldispatch.c
@@ -1547,36 +1547,32 @@ static HRESULT WINAPI FolderImpl_ParseName(Folder3 *iface, BSTR name, FolderItem
     return hr;
 }
 
-static HRESULT WINAPI FolderImpl_NewFolder(Folder3 *iface, BSTR bName,
-        VARIANT vOptions)
+static HRESULT WINAPI FolderImpl_NewFolder(Folder3 *iface, BSTR name, VARIANT options)
 {
-    FIXME("(%p,%s)\n", iface, debugstr_w(bName));
+    FIXME("(%p,%s,%s)\n", iface, debugstr_w(name), debugstr_variant(&options));
 
     return E_NOTIMPL;
 }
 
-static HRESULT WINAPI FolderImpl_MoveHere(Folder3 *iface, VARIANT vItem,
-        VARIANT vOptions)
+static HRESULT WINAPI FolderImpl_MoveHere(Folder3 *iface, VARIANT item, VARIANT options)
 {
-    FIXME("(%p)\n", iface);
+    FIXME("(%p,%s,%s)\n", iface, debugstr_variant(&item), debugstr_variant(&options));
 
     return E_NOTIMPL;
 }
 
-static HRESULT WINAPI FolderImpl_CopyHere(Folder3 *iface, VARIANT vItem,
-        VARIANT vOptions)
+static HRESULT WINAPI FolderImpl_CopyHere(Folder3 *iface, VARIANT item, VARIANT options)
 {
-    FIXME("(%p)\n", iface);
+    FIXME("(%p,%s,%s)\n", iface, debugstr_variant(&item), debugstr_variant(&options));
 
     return E_NOTIMPL;
 }
 
-static HRESULT WINAPI FolderImpl_GetDetailsOf(Folder3 *iface, VARIANT vItem,
-        int iColumn, BSTR *pbs)
+static HRESULT WINAPI FolderImpl_GetDetailsOf(Folder3 *iface, VARIANT item, int column, BSTR *str)
 {
-    FIXME("(%p,%d,%p)\n", iface, iColumn, pbs);
+    FIXME("(%p,%s,%d,%p)\n", iface, debugstr_variant(&item), column, str);
 
-    *pbs = NULL;
+    *str = NULL;
     return E_NOTIMPL;
 }
 
@@ -1877,7 +1873,7 @@ static HRESULT WINAPI ShellDispatch_NameSpace(IShellDispatch6 *iface,
 static HRESULT WINAPI ShellDispatch_BrowseForFolder(IShellDispatch6 *iface,
         LONG Hwnd, BSTR Title, LONG Options, VARIANT RootFolder, Folder **ppsdf)
 {
-    FIXME("(%p,%x,%s,%x,%p)\n", iface, Hwnd, debugstr_w(Title), Options, ppsdf);
+    FIXME("(%p,%x,%s,%x,%s,%p)\n", iface, Hwnd, debugstr_w(Title), Options, debugstr_variant(&RootFolder), ppsdf);
 
     *ppsdf = NULL;
     return E_NOTIMPL;
@@ -1892,16 +1888,16 @@ static HRESULT WINAPI ShellDispatch_Windows(IShellDispatch6 *iface,
     return E_NOTIMPL;
 }
 
-static HRESULT WINAPI ShellDispatch_Open(IShellDispatch6 *iface, VARIANT vDir)
+static HRESULT WINAPI ShellDispatch_Open(IShellDispatch6 *iface, VARIANT dir)
 {
-    FIXME("(%p)\n", iface);
+    FIXME("(%p,%s)\n", iface, debugstr_variant(&dir));
 
     return E_NOTIMPL;
 }
 
-static HRESULT WINAPI ShellDispatch_Explore(IShellDispatch6 *iface, VARIANT vDir)
+static HRESULT WINAPI ShellDispatch_Explore(IShellDispatch6 *iface, VARIANT dir)
 {
-    FIXME("(%p)\n", iface);
+    FIXME("(%p,%s)\n", iface, debugstr_variant(&dir));
 
     return E_NOTIMPL;
 }
@@ -2080,13 +2076,13 @@ static HRESULT WINAPI ShellDispatch_GetSystemInformation(IShellDispatch6 *iface,
 
 static HRESULT WINAPI ShellDispatch_ServiceStart(IShellDispatch6 *iface, BSTR service, VARIANT persistent, VARIANT *ret)
 {
-    FIXME("(%s, %p): stub\n", debugstr_w(service), ret);
+    FIXME("(%s, %s, %p): stub\n", debugstr_w(service), debugstr_variant(&persistent), ret);
     return E_NOTIMPL;
 }
 
 static HRESULT WINAPI ShellDispatch_ServiceStop(IShellDispatch6 *iface, BSTR service, VARIANT persistent, VARIANT *ret)
 {
-    FIXME("(%s, %p): stub\n", debugstr_w(service), ret);
+    FIXME("(%s, %s, %p): stub\n", debugstr_w(service), debugstr_variant(&persistent), ret);
     return E_NOTIMPL;
 }
 
@@ -2142,13 +2138,13 @@ static HRESULT WINAPI ShellDispatch_CanStartStopService(IShellDispatch6 *iface,
 
 static HRESULT WINAPI ShellDispatch_ShowBrowserBar(IShellDispatch6 *iface, BSTR clsid, VARIANT show, VARIANT *ret)
 {
-    FIXME("(%s, %p): stub\n", debugstr_w(clsid), ret);
+    FIXME("(%s, %s, %p): stub\n", debugstr_w(clsid), debugstr_variant(&show), ret);
     return E_NOTIMPL;
 }
 
 static HRESULT WINAPI ShellDispatch_AddToRecent(IShellDispatch6 *iface, VARIANT file, BSTR category)
 {
-    FIXME("(%s): stub\n", debugstr_w(category));
+    FIXME("(%s, %s): stub\n", debugstr_variant(&file), debugstr_w(category));
     return E_NOTIMPL;
 }
 




More information about the wine-cvs mailing list