Francois Gouget : testbot: Standardize the packages inheritance and exports.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: c3737f9a96195acace98ec94aebde638207d7e9f
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=c3737f9a96195acace98ec94aebde638207d7e9f

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Apr 19 03:34:42 2018 +0200

testbot: Standardize the packages inheritance and exports.

Use "our" instead of the antiquated 'use vars'.
Use "use Exporter 'import'" as this form avoid exporting the whole
Exporter interface from each of our package. This means we can also drop
@ISA in those cases where we don't need to inherit from another package.
Also we don't need the Exporter module just to inherit an interface so
remove unneeded uses of Exporter.
Defining the package inheritance and public interface does not depend on
the rest of the package so move these statements first, even before all
the other imports.
Remove the ampersands from the exported functions names: they are
unnecessary (and reportedly slower).

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/BackEnd.pm                  |  7 ++-----
 testbot/lib/ObjectModel/BasicPropertyDescriptor.pm  |  8 +++-----
 testbot/lib/ObjectModel/CGI/CollectionBlock.pm      |  9 +++------
 .../lib/ObjectModel/CGI/CollectionBlockForPage.pm   |  5 +----
 testbot/lib/ObjectModel/CGI/CollectionPage.pm       |  7 ++-----
 testbot/lib/ObjectModel/CGI/FormPage.pm             |  5 +----
 testbot/lib/ObjectModel/CGI/FreeFormPage.pm         |  6 +-----
 testbot/lib/ObjectModel/CGI/ItemPage.pm             |  7 ++-----
 testbot/lib/ObjectModel/CGI/Page.pm                 |  8 ++++----
 testbot/lib/ObjectModel/Collection.pm               |  7 ++-----
 testbot/lib/ObjectModel/DBIBackEnd.pm               | 12 +++++-------
 .../lib/ObjectModel/DetailrefPropertyDescriptor.pm  |  8 ++++----
 testbot/lib/ObjectModel/EnumPropertyDescriptor.pm   |  8 +++-----
 testbot/lib/ObjectModel/Item.pm                     |  8 +++-----
 .../lib/ObjectModel/ItemrefPropertyDescriptor.pm    |  9 ++++-----
 testbot/lib/ObjectModel/PropertyDescriptor.pm       |  4 ----
 testbot/lib/WineTestBot/Activity.pm                 |  9 +++------
 testbot/lib/WineTestBot/Branches.pm                 | 16 +++++++---------
 testbot/lib/WineTestBot/CGI/PageBase.pm             |  9 +++------
 testbot/lib/WineTestBot/CGI/Sessions.pm             | 18 +++++++-----------
 testbot/lib/WineTestBot/Engine/Events.pm            |  6 ++----
 testbot/lib/WineTestBot/Engine/Notify.pm            | 16 +++++++---------
 testbot/lib/WineTestBot/Jobs.pm                     | 20 ++++++++------------
 testbot/lib/WineTestBot/LibvirtDomain.pm            |  8 +++-----
 testbot/lib/WineTestBot/Log.pm                      |  9 +++------
 testbot/lib/WineTestBot/Patches.pm                  | 21 +++++++++------------
 testbot/lib/WineTestBot/PendingPatchSets.pm         | 20 ++++++++------------
 testbot/lib/WineTestBot/PendingPatches.pm           | 17 ++++++-----------
 testbot/lib/WineTestBot/RecordGroups.pm             | 18 ++++++------------
 testbot/lib/WineTestBot/Records.pm                  | 18 +++++++-----------
 testbot/lib/WineTestBot/Roles.pm                    | 16 +++++-----------
 testbot/lib/WineTestBot/Steps.pm                    | 20 ++++++++------------
 testbot/lib/WineTestBot/StepsTasks.pm               | 19 ++++++++-----------
 testbot/lib/WineTestBot/Tasks.pm                    | 21 ++++++++-------------
 testbot/lib/WineTestBot/TestAgent.pm                | 17 +++++++----------
 testbot/lib/WineTestBot/UserRoles.pm                | 17 ++++++-----------
 testbot/lib/WineTestBot/Users.pm                    | 21 +++++++++------------
 testbot/lib/WineTestBot/Utils.pm                    | 12 +++++-------
 testbot/lib/WineTestBot/VMs.pm                      | 20 ++++++++------------
 testbot/lib/WineTestBot/WineTestBotObjects.pm       | 18 +++++++-----------
 testbot/web/index.pl                                | 17 +++++++++--------
 41 files changed, 199 insertions(+), 322 deletions(-)

Diff:   https://source.winehq.org/git/tools.git/?a=commitdiff;h=c3737f9a96195acace98ec94aebde638207d7e9f