Alexandre Julliard : shell32/tests: Don' t use strncat with known large enough buffer.
Alexandre Julliard
julliard at winehq.org
Wed Aug 15 14:39:53 CDT 2018
Module: wine
Branch: master
Commit: 3386c01349ee05e99e89861877ff71a2ddd4eb5e
URL: https://source.winehq.org/git/wine.git/?a=commit;h=3386c01349ee05e99e89861877ff71a2ddd4eb5e
Author: Alexandre Julliard <julliard at winehq.org>
Date: Wed Aug 15 07:08:50 2018 +0200
shell32/tests: Don't use strncat with known large enough buffer.
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/shell32/tests/brsfolder.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dlls/shell32/tests/brsfolder.c b/dlls/shell32/tests/brsfolder.c
index bf29d11..0888cfa 100644
--- a/dlls/shell32/tests/brsfolder.c
+++ b/dlls/shell32/tests/brsfolder.c
@@ -44,8 +44,8 @@ static int get_number_of_folders(LPCSTR path)
WIN32_FIND_DATAA find_data;
HANDLE find_handle;
- lstrcpynA(path_search_string, path, MAX_PATH);
- strncat(path_search_string, "*", 1);
+ lstrcpynA(path_search_string, path, MAX_PATH - 1);
+ strcat(path_search_string, "*");
find_handle = FindFirstFileA(path_search_string, &find_data);
if (find_handle == INVALID_HANDLE_VALUE)
@@ -186,9 +186,9 @@ static void test_click_make_new_folder_button(void)
{
skip("GetCurrentDirectoryA failed %u\n", GetLastError());
}
- strncat(test_folder_path, "\\", 1);
- strncat(test_folder_path, title, MAX_PATH-1);
- strncat(test_folder_path, "\\", 1);
+ strcat(test_folder_path, "\\");
+ strcat(test_folder_path, title);
+ strcat(test_folder_path, "\\");
/* Avoid conflicts by creating a test folder. */
if (!CreateDirectoryA(title, NULL))
More information about the wine-cvs
mailing list