Paul Gofman : d3d8: Fix crash in d3d8_indexbuffer_Release().

Alexandre Julliard julliard at winehq.org
Thu Dec 20 14:25:28 CST 2018


Module: wine
Branch: master
Commit: f6896e062d30d6d5d6d94a34e3a622c83aa9d3f1
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=f6896e062d30d6d5d6d94a34e3a622c83aa9d3f1

Author: Paul Gofman <gofmanp at gmail.com>
Date:   Tue Dec 18 19:57:25 2018 +0300

d3d8: Fix crash in d3d8_indexbuffer_Release().

Signed-off-by: Paul Gofman <gofmanp at gmail.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/d3d8/buffer.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/d3d8/buffer.c b/dlls/d3d8/buffer.c
index 887ecf4..3b98000 100644
--- a/dlls/d3d8/buffer.c
+++ b/dlls/d3d8/buffer.c
@@ -395,12 +395,13 @@ static ULONG WINAPI d3d8_indexbuffer_Release(IDirect3DIndexBuffer8 *iface)
 
     if (!refcount)
     {
+        struct wined3d_buffer *draw_buffer = buffer->draw_buffer;
         IDirect3DDevice8 *device = buffer->parent_device;
 
         wined3d_mutex_lock();
         wined3d_buffer_decref(buffer->wined3d_buffer);
-        if (buffer->draw_buffer)
-            wined3d_buffer_decref(buffer->draw_buffer);
+        if (draw_buffer)
+            wined3d_buffer_decref(draw_buffer);
         wined3d_mutex_unlock();
 
         /* Release the device last, as it may cause the device to be destroyed. */




More information about the wine-cvs mailing list