Francois Gouget : testbot/web: Add the job' s remarks as a tooltip on the activity page.

Alexandre Julliard julliard at winehq.org
Tue Feb 6 15:09:38 CST 2018


Module: tools
Branch: master
Commit: ad65021749ba75744e5b3decb63010efe1b2e072
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=ad65021749ba75744e5b3decb63010efe1b2e072

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Feb  6 03:12:10 2018 +0100

testbot/web: Add the job's remarks as a tooltip on the activity page.

This allows getting a quick sense of what the task is about without
having to change page or bloating the content of the table.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/web/Activity.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/testbot/web/Activity.pl b/testbot/web/Activity.pl
index 6ca3199..13c77c6 100644
--- a/testbot/web/Activity.pl
+++ b/testbot/web/Activity.pl
@@ -228,7 +228,9 @@ EOF
             $Label .= "/64" if ($Bitness);
           }
         }
-        $Label = "<a href='/JobDetails.pl?Key=". $VMStatus->{job}->Id ."#k". ($VMStatus->{step}->No * 100 + $VMStatus->{task}->No) ."'>$Label</a>";
+        my $Key = $VMStatus->{job}->Id ."#k". ($VMStatus->{step}->No * 100 + $VMStatus->{task}->No);
+        my $Title = $self->escapeHTML($VMStatus->{job}->Remarks);
+        $Label = "<a href='/JobDetails.pl?Key=$Key' title='$Title'>$Label</a>";
       }
       elsif ($VMStatus->{status} eq "dirty")
       {




More information about the wine-cvs mailing list