Henri Verbeet : usp10: Avoid leaking "open_stack" and "stack_index" in case of 0 "pair_count" in computeBracketPairs().

Alexandre Julliard julliard at winehq.org
Mon Feb 19 13:52:01 CST 2018


Module: wine
Branch: master
Commit: 99e61cee75d705b6f67a6a832ac9f6815bab58ab
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=99e61cee75d705b6f67a6a832ac9f6815bab58ab

Author: Henri Verbeet <hverbeet at codeweavers.com>
Date:   Sun Feb 18 21:56:37 2018 +0330

usp10: Avoid leaking "open_stack" and "stack_index" in case of 0 "pair_count" in computeBracketPairs().

Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Aric Stewart <aric at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/usp10/bidi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/usp10/bidi.c b/dlls/usp10/bidi.c
index d94dc7b..8f94ede 100644
--- a/dlls/usp10/bidi.c
+++ b/dlls/usp10/bidi.c
@@ -741,6 +741,10 @@ static BracketPair *computeBracketPairs(IsolatedRun *iso_run)
             }
         }
     }
+
+    heap_free(open_stack);
+    heap_free(stack_index);
+
     if (pair_count == 0)
     {
         heap_free(out);
@@ -749,8 +753,6 @@ static BracketPair *computeBracketPairs(IsolatedRun *iso_run)
     else if (pair_count > 1)
         qsort(out, pair_count, sizeof(BracketPair), compr);
 
-    heap_free(open_stack);
-    heap_free(stack_index);
     return out;
 }
 




More information about the wine-cvs mailing list