Alex Henrie : shell32/tests: Add missing return value check to shelllink tests (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Jan 8 16:08:06 CST 2018


Module: wine
Branch: master
Commit: 8bb6addb1ea15072cfbe60dc12602d515be7e018
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=8bb6addb1ea15072cfbe60dc12602d515be7e018

Author: Alex Henrie <alexhenrie24 at gmail.com>
Date:   Sun Jan  7 22:05:18 2018 -0700

shell32/tests: Add missing return value check to shelllink tests (Coverity).

Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/shell32/tests/shelllink.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c
index 6f12fb2..4f16290 100644
--- a/dlls/shell32/tests/shelllink.c
+++ b/dlls/shell32/tests/shelllink.c
@@ -169,8 +169,9 @@ static void test_get_set(void)
     ok(finddata.dwFileAttributes == 0, "unexpected attributes %x\n", finddata.dwFileAttributes);
     ok(finddata.cFileName[0] == 0, "unexpected filename '%s'\n", finddata.cFileName);
 
-    CoCreateInstance(&CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER,
-                     &IID_IShellLinkW, (LPVOID*)&slW);
+    r = CoCreateInstance(&CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER,
+                         &IID_IShellLinkW, (LPVOID*)&slW);
+    ok(r == S_OK, "CoCreateInstance failed (0x%08x)\n", r);
     if (!slW /* Win9x */ || !pGetLongPathNameA /* NT4 */)
         skip("SetPath with NULL parameter crashes on Win9x and some NT4\n");
     else




More information about the wine-cvs mailing list