Nikolay Sivov : mshtml/tests: Skip some tests if native XMLHTTP support is missing or disabled.

Alexandre Julliard julliard at winehq.org
Mon Jan 8 16:08:07 CST 2018


Module: wine
Branch: master
Commit: 3cb8e4bdc84c3458a0f1979a383266e02ca79d73
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=3cb8e4bdc84c3458a0f1979a383266e02ca79d73

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Mon Jan  8 17:00:06 2018 +0300

mshtml/tests: Skip some tests if native XMLHTTP support is missing or disabled.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/tests/dom.c       |  7 ++++++-
 dlls/mshtml/tests/jstest.html | 13 ++++++++-----
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index b003467..2a4ae62 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -6683,7 +6683,12 @@ static void test_xmlhttprequest(IHTMLWindow5 *window)
 
     hres = IHTMLWindow5_get_XMLHttpRequest(window, &var);
     ok(hres == S_OK, "get_XMLHttpRequest failed: %08x\n", hres);
-    ok(V_VT(&var) == VT_DISPATCH, "expect VT_DISPATCH, got %s\n", debugstr_variant(&var));
+    ok(V_VT(&var) == VT_DISPATCH || broken(V_VT(&var) == VT_EMPTY), "expect VT_DISPATCH, got %s\n", debugstr_variant(&var));
+
+    if (V_VT(&var) == VT_EMPTY) {
+        win_skip("Native XMLHTTP support is missing or disabled.\n");
+        return;
+    }
 
     factory = NULL;
     hres = IDispatch_QueryInterface(V_DISPATCH(&var), &IID_IHTMLXMLHttpRequestFactory, (void**)&factory);
diff --git a/dlls/mshtml/tests/jstest.html b/dlls/mshtml/tests/jstest.html
index cce8050..164593e 100644
--- a/dlls/mshtml/tests/jstest.html
+++ b/dlls/mshtml/tests/jstest.html
@@ -1,10 +1,9 @@
 <html>
 <head>
+<script src="winetest.js" type="text/javascript"></script>
+</head>
+<head>
 <script>
-function ok(b,m) {
-    return external.ok(b, m);
-}
-
 function broken(expr) {
     return external.broken(expr);
 }
@@ -356,7 +355,11 @@ function test_text_node() {
 
 function test_xhr() {
     ok("XMLHttpRequest" in window, "XMLHttpRequest not found in window object\n");
-    ok(typeof(XMLHttpRequest) === "object", "typeof(XMLHttpRequest) = " + typeof(XMLHttpRequest));
+
+    if (typeof(XMLHttpRequest) != "object") {
+        win_skip("XMLHTTPRequest is not available or disabled");
+        return;
+    }
 
     var xhr = new XMLHttpRequest();
     ok(typeof(xhr) === "object", "typeof(xhr) = " + typeof(xhr));




More information about the wine-cvs mailing list