Matteo Bruni : advapi32/tests: Fully initialize ACLs (Valgrind).
Alexandre Julliard
julliard at winehq.org
Wed Jan 10 17:06:30 CST 2018
Module: wine
Branch: master
Commit: f6f5c96677be7dfd7fc62b80fb822fdfa7b1c4fd
URL: https://source.winehq.org/git/wine.git/?a=commit;h=f6f5c96677be7dfd7fc62b80fb822fdfa7b1c4fd
Author: Matteo Bruni <mbruni at codeweavers.com>
Date: Wed Jan 10 22:59:03 2018 +0100
advapi32/tests: Fully initialize ACLs (Valgrind).
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/advapi32/tests/security.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c
index 51dcf90..a710174 100644
--- a/dlls/advapi32/tests/security.c
+++ b/dlls/advapi32/tests/security.c
@@ -3559,7 +3559,7 @@ static void test_CreateDirectoryA(void)
sa.bInheritHandle = TRUE;
InitializeSecurityDescriptor(pSD, SECURITY_DESCRIPTOR_REVISION);
pCreateWellKnownSid(WinBuiltinAdministratorsSid, NULL, admin_sid, &sid_size);
- pDacl = HeapAlloc(GetProcessHeap(), 0, 100);
+ pDacl = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 100);
bret = InitializeAcl(pDacl, 100, ACL_REVISION);
ok(bret, "Failed to initialize ACL.\n");
bret = pAddAccessAllowedAceEx(pDacl, ACL_REVISION, OBJECT_INHERIT_ACE|CONTAINER_INHERIT_ACE,
@@ -6306,6 +6306,7 @@ static void test_AddMandatoryAce(void)
HeapFree(GetProcessHeap(), 0, sd2);
CloseHandle(handle);
+ memset(buffer_acl, 0, sizeof(buffer_acl));
ret = InitializeAcl(acl, 256, ACL_REVISION);
ok(ret, "InitializeAcl failed with %u\n", GetLastError());
@@ -6792,6 +6793,7 @@ static void test_maximum_allowed(void)
ret = InitializeSecurityDescriptor(sd, SECURITY_DESCRIPTOR_REVISION);
ok(ret, "InitializeSecurityDescriptor failed with %u\n", GetLastError());
+ memset(buffer_acl, 0, sizeof(buffer_acl));
ret = InitializeAcl(acl, 256, ACL_REVISION);
ok(ret, "InitializeAcl failed with %u\n", GetLastError());
ret = SetSecurityDescriptorDacl(sd, TRUE, acl, FALSE);
@@ -6921,6 +6923,7 @@ static void test_token_security_descriptor(void)
ret = InitializeSecurityDescriptor(sd, SECURITY_DESCRIPTOR_REVISION);
ok(ret, "InitializeSecurityDescriptor failed with error %u\n", GetLastError());
+ memset(buffer_acl, 0, sizeof(buffer_acl));
ret = InitializeAcl(acl, 256, ACL_REVISION);
ok(ret, "InitializeAcl failed with error %u\n", GetLastError());
More information about the wine-cvs
mailing list