Zebediah Figura : strmbase: Update comment for copying pin info.

Alexandre Julliard julliard at winehq.org
Thu Jul 5 15:25:54 CDT 2018


Module: wine
Branch: master
Commit: 567be5b60ee6c165828f6a43b252299b5f9f6dcc
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=567be5b60ee6c165828f6a43b252299b5f9f6dcc

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Thu Jul  5 00:43:24 2018 +0200

strmbase: Update comment for copying pin info.

Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/strmbase/pin.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/dlls/strmbase/pin.c b/dlls/strmbase/pin.c
index ef22a57..a100ae1 100644
--- a/dlls/strmbase/pin.c
+++ b/dlls/strmbase/pin.c
@@ -145,10 +145,7 @@ out:
 
 static void Copy_PinInfo(PIN_INFO * pDest, const PIN_INFO * pSrc)
 {
-    /* Tempting to just do a memcpy, but the name field is
-       128 characters long! We will probably never exceed 10
-       most of the time, so we are better off copying
-       each field manually */
+    /* avoid copying uninitialized data */
     strcpyW(pDest->achName, pSrc->achName);
     pDest->dir = pSrc->dir;
     pDest->pFilter = pSrc->pFilter;




More information about the wine-cvs mailing list