Hugh McMaster : regedit: Do not overwrite a hex data type with REG_BINARY when modifying a value.

Alexandre Julliard julliard at winehq.org
Mon Jul 16 14:40:00 CDT 2018


Module: wine
Branch: master
Commit: 6b620e6d615df5041918b0037fe7fd988c7b20d0
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=6b620e6d615df5041918b0037fe7fd988c7b20d0

Author: Hugh McMaster <hugh.mcmaster at outlook.com>
Date:   Mon Jul 16 12:20:50 2018 +0000

regedit: Do not overwrite a hex data type with REG_BINARY when modifying a value.

Signed-off-by: Hugh McMaster <hugh.mcmaster at outlook.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 programs/regedit/edit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/programs/regedit/edit.c b/programs/regedit/edit.c
index de96ded..a3cf17b 100644
--- a/programs/regedit/edit.c
+++ b/programs/regedit/edit.c
@@ -40,6 +40,7 @@ struct edit_params
 {
     HKEY         hkey;
     const WCHAR *value_name;
+    DWORD        type;
     void        *data;
     DWORD        size;
 };
@@ -159,7 +160,7 @@ static INT_PTR CALLBACK bin_modify_dlgproc(HWND hwndDlg, UINT uMsg, WPARAM wPara
             data = heap_xalloc(size);
 
             SendDlgItemMessageW(hwndDlg, IDC_VALUE_DATA, HEM_GETDATA, (WPARAM)size, (LPARAM)data);
-            lRet = RegSetValueExW(params->hkey, params->value_name, 0, REG_BINARY, data, size);
+            lRet = RegSetValueExW(params->hkey, params->value_name, 0, params->type, data, size);
             heap_free(data);
 
             if (lRet == ERROR_SUCCESS)
@@ -351,6 +352,7 @@ BOOL ModifyValue(HWND hwnd, HKEY hKeyRoot, LPCWSTR keyPath, LPCWSTR valueName)
 
         params.hkey = hKey;
         params.value_name = valueName;
+        params.type = type;
         params.data = stringValueData;
         params.size = len;
         result = DialogBoxParamW(NULL, MAKEINTRESOURCEW(IDD_EDIT_BINARY), hwnd,




More information about the wine-cvs mailing list