Francois Gouget : testbot: Standardize on push to append to an array.
Alexandre Julliard
julliard at winehq.org
Fri Mar 2 08:59:41 CST 2018
Module: tools
Branch: master
Commit: e3d8e20c892ed616e6566087d87a6dff80de9dfa
URL: https://source.winehq.org/git/tools.git/?a=commit;h=e3d8e20c892ed616e6566087d87a6dff80de9dfa
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Fri Mar 2 01:22:51 2018 +0100
testbot: Standardize on push to append to an array.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
testbot/bin/WineSendLog.pl | 4 ++--
testbot/lib/ObjectModel/Item.pm | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index 62024d9..ec9a587 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -297,7 +297,7 @@ EOF
}
else
{
- $FailureKeys[scalar @FailureKeys] = $Key;
+ push @FailureKeys, $Key;
}
}
elsif (open ERRFILE, "<$TaskDir/err")
@@ -317,7 +317,7 @@ EOF
}
else
{
- $FailureKeys[scalar @FailureKeys] = $Key;
+ push @FailureKeys, $Key;
}
}
}
diff --git a/testbot/lib/ObjectModel/Item.pm b/testbot/lib/ObjectModel/Item.pm
index 6296130..e1385b8 100644
--- a/testbot/lib/ObjectModel/Item.pm
+++ b/testbot/lib/ObjectModel/Item.pm
@@ -320,8 +320,8 @@ sub GetMasterKey($)
{
foreach my $ColName (@{$PropertyDescriptor->GetColNames()})
{
- @MasterColNames[scalar @MasterColNames] = $ColNamePrefix . $ColName;
- @MasterColValues[scalar @MasterColValues] = $self->GetColValue($ColName);
+ push @MasterColNames, $ColNamePrefix . $ColName;
+ push @MasterColValues, $self->GetColValue($ColName);
}
}
}
More information about the wine-cvs
mailing list