Francois Gouget : testbot: Standardize some pushes.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: f318eb5bd4c16c4cc833333d1c66836486e487ef
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=f318eb5bd4c16c4cc833333d1c66836486e487ef

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Fri Mar 23 01:19:18 2018 +0100

testbot: Standardize some pushes.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/DBIBackEnd.pm | 16 ++++++++--------
 testbot/web/Feedback.pl               |  2 +-
 testbot/web/ForgotPassword.pl         |  2 +-
 testbot/web/Login.pl                  |  2 +-
 testbot/web/ResetPassword.pl          |  2 +-
 testbot/web/Submit.pl                 |  8 ++++----
 testbot/web/admin/Log.pl              |  2 +-
 testbot/web/admin/UserDetails.pl      |  2 +-
 8 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/testbot/lib/ObjectModel/DBIBackEnd.pm b/testbot/lib/ObjectModel/DBIBackEnd.pm
index a508f66..0016e19 100644
--- a/testbot/lib/ObjectModel/DBIBackEnd.pm
+++ b/testbot/lib/ObjectModel/DBIBackEnd.pm
@@ -198,7 +198,7 @@ sub LoadCollection($$)
   if (defined($MasterColNames))
   {
     $Where = join(" = ? AND ", @{$MasterColNames}) . " = ?";
-    push(@Data, @{$MasterColValues});
+    push @Data, @{$MasterColValues};
   }
 
   my $Filters = $Collection->GetFilters();
@@ -299,11 +299,11 @@ sub LoadItem($$$)
   if (defined($MasterColNames))
   {
     $Where = join(" = ? AND ", @{$MasterColNames}) . " = ?";
-    push(@Data, @{$MasterColValues});
+    push @Data, @{$MasterColValues};
   }
   $Where = $self->BuildKeyWhere($Collection->GetPropertyDescriptors(), "",
                                 $Where);
-  push(@Data, $Collection->SplitKey($RequestedKey));
+  push @Data, $Collection->SplitKey($RequestedKey);
 
   my $Query = "SELECT $Fields FROM " . $Collection->GetTableName();
   if ($Where ne "")
@@ -378,7 +378,7 @@ sub GetInsertData($$$)
   my @Data;
   if (defined($MasterColValues))
   {
-    push(@Data, @$MasterColValues);
+    push @Data, @$MasterColValues;
   }
 
   foreach my $PropertyDescriptor (@{$Item->GetPropertyDescriptors()})
@@ -442,7 +442,7 @@ sub GetUpdateData($$$)
 
   if (defined($MasterColValues))
   {
-    push(@Data, @$MasterColValues);
+    push @Data, @$MasterColValues;
   }
 
   foreach my $PropertyDescriptor (@{$Item->GetPropertyDescriptors()})
@@ -550,11 +550,11 @@ sub DeleteItem($$)
   if (defined($MasterColNames))
   {
     $Where = join(" = ? AND ", @{$MasterColNames}) . " = ?";
-    push(@Data, @{$MasterColValues});
+    push @Data, @{$MasterColValues};
   }
   $Where = $self->BuildKeyWhere($Item->GetPropertyDescriptors(), "",
                                 $Where);
-  push(@Data, $Item->GetKeyComponents());
+  push @Data, $Item->GetKeyComponents();
 
   my $Statement = $self->GetDb()->prepare("DELETE FROM " .
                                           $Item->GetTableName() .
@@ -575,7 +575,7 @@ sub DeleteAll($$)
   if (defined($MasterColNames))
   {
     $Where = join(" = ? AND ", @{$MasterColNames}) . " = ?";
-    push(@Data, @{$MasterColValues});
+    push @Data, @{$MasterColValues};
   }
 
   my $Query = "DELETE FROM " . $Collection->GetTableName();
diff --git a/testbot/web/Feedback.pl b/testbot/web/Feedback.pl
index ded705a..2480243 100644
--- a/testbot/web/Feedback.pl
+++ b/testbot/web/Feedback.pl
@@ -68,7 +68,7 @@ sub GetActions($)
   my ($self) = @_;
 
   my $Actions = $self->SUPER::GetActions();
-  push(@$Actions, "Send");
+  push @$Actions, "Send";
 
   return $Actions;
 }
diff --git a/testbot/web/ForgotPassword.pl b/testbot/web/ForgotPassword.pl
index c6240e7..3c94c27 100644
--- a/testbot/web/ForgotPassword.pl
+++ b/testbot/web/ForgotPassword.pl
@@ -61,7 +61,7 @@ sub GetActions($)
   my ($self) = @_;
 
   my $Actions = $self->SUPER::GetActions();
-  push(@$Actions, "Reset password");
+  push @$Actions, "Reset password";
 
   return $Actions;
 }
diff --git a/testbot/web/Login.pl b/testbot/web/Login.pl
index f17d60e..b5b6365 100644
--- a/testbot/web/Login.pl
+++ b/testbot/web/Login.pl
@@ -89,7 +89,7 @@ sub GetActions($)
   my ($self) = @_;
 
   my $Actions = $self->SUPER::GetActions();
-  push(@$Actions, "Log in");
+  push @$Actions, "Log in";
 
   return $Actions;
 }
diff --git a/testbot/web/ResetPassword.pl b/testbot/web/ResetPassword.pl
index 431a4da..db129db 100644
--- a/testbot/web/ResetPassword.pl
+++ b/testbot/web/ResetPassword.pl
@@ -75,7 +75,7 @@ sub GetActions($)
   my ($self) = @_;
 
   my $Actions = $self->SUPER::GetActions();
-  push(@$Actions, "Change password");
+  push @$Actions, "Change password";
 
   return $Actions;
 }
diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 875384e..9bf1781 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -358,19 +358,19 @@ sub GetActions($)
   my $Actions = $self->SUPER::GetActions();
   if ($self->{Page} == 1)
   {
-    push(@$Actions, "Next >");
+    push @$Actions, "Next >";
   }
   elsif ($self->{Page} == 2)
   {
-    push(@$Actions, "< Prev", "Next >");
+    push @$Actions, "< Prev", "Next >";
   }
   elsif ($self->{Page} == 3)
   {
-    push(@$Actions, "< Prev", "Submit");
+    push @$Actions, "< Prev", "Submit";
   }
   elsif ($self->{Page} == 4)
   {
-    push(@$Actions, "OK");
+    push @$Actions, "OK";
   }
 
   return $Actions;
diff --git a/testbot/web/admin/Log.pl b/testbot/web/admin/Log.pl
index b9754bd..3ad35a4 100644
--- a/testbot/web/admin/Log.pl
+++ b/testbot/web/admin/Log.pl
@@ -59,7 +59,7 @@ sub GetActions($)
   my ($self) = @_;
 
   my $Actions = $self->SUPER::GetActions();
-  push(@$Actions, "Download");
+  push @$Actions, "Download";
 
   return $Actions;
 }
diff --git a/testbot/web/admin/UserDetails.pl b/testbot/web/admin/UserDetails.pl
index d24e675..28eb4b5 100644
--- a/testbot/web/admin/UserDetails.pl
+++ b/testbot/web/admin/UserDetails.pl
@@ -61,7 +61,7 @@ sub GetActions($)
     push @Actions, "Reject" if ($self->{Item}->Name);
   }
 
-  push(@Actions, @{$self->SUPER::GetActions()});
+  push @Actions, @{$self->SUPER::GetActions()};
 
   return \@Actions;
 }