Francois Gouget : testbot/web: Tweak ItemPage to save the Item directly.

Alexandre Julliard julliard at winehq.org
Mon Mar 26 14:13:46 CDT 2018


Module: tools
Branch: master
Commit: c18379abe004411ca779d4c42e26d7e7f3d72ba6
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=c18379abe004411ca779d4c42e26d7e7f3d72ba6

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Mar 26 05:21:05 2018 +0200

testbot/web: Tweak ItemPage to save the Item directly.

This avoids depending on whether Items retrieved with
Collection::GetItem() are stored in the Collection or not.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/CGI/ItemPage.pm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index 4086a93..b44e5b2 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -137,6 +137,16 @@ sub SaveProperty($$$)
   return 1;
 }
 
+sub Save($)
+{
+  my ($self) = @_;
+
+  return !1 if (!$self->SaveProperties());
+
+  ($self->{ErrField}, $self->{ErrMessage}) = $self->{Item}->Save();
+  return ! defined($self->{ErrMessage});
+}
+
 sub OnAction($$)
 {
   my ($self, $Action) = @_;




More information about the wine-cvs mailing list