Dmitry Timoshkov : advapi32: Use larger buffers for domain names.
Alexandre Julliard
julliard at winehq.org
Thu Mar 29 19:13:29 CDT 2018
Module: wine
Branch: master
Commit: 923f7246be21334ebe6ec19ced55d4d5cbed60eb
URL: https://source.winehq.org/git/wine.git/?a=commit;h=923f7246be21334ebe6ec19ced55d4d5cbed60eb
Author: Dmitry Timoshkov <dmitry at baikal.ru>
Date: Thu Mar 29 09:52:48 2018 +0800
advapi32: Use larger buffers for domain names.
Otherwise GetComputerNameExW(ComputerNamePhysicalDnsDomain) and
GetComputerNameExW(ComputerNameDnsDomain) fail if the names don't
fit into MAX_COMPUTERNAME_LENGTH characters.
Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/advapi32/lsa.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dlls/advapi32/lsa.c b/dlls/advapi32/lsa.c
index 95bfe09..354db65 100644
--- a/dlls/advapi32/lsa.c
+++ b/dlls/advapi32/lsa.c
@@ -771,9 +771,9 @@ NTSTATUS WINAPI LsaQueryInformationPolicy(
SID sid;
DWORD sid_subauthority[3];
} domain_sid;
- WCHAR domain_name[MAX_COMPUTERNAME_LENGTH + 1];
- WCHAR dns_domain_name[MAX_COMPUTERNAME_LENGTH + 1];
- WCHAR dns_forest_name[MAX_COMPUTERNAME_LENGTH + 1];
+ WCHAR domain_name[256];
+ WCHAR dns_domain_name[256];
+ WCHAR dns_forest_name[256];
} *xdi;
struct
{
@@ -785,7 +785,7 @@ NTSTATUS WINAPI LsaQueryInformationPolicy(
xdi = heap_alloc_zero(sizeof(*xdi));
if (!xdi) return STATUS_NO_MEMORY;
- dwSize = MAX_COMPUTERNAME_LENGTH + 1;
+ dwSize = 256;
if (GetComputerNameExW(ComputerNamePhysicalDnsDomain, xdi->domain_name, &dwSize))
{
WCHAR *dot;
@@ -799,7 +799,7 @@ NTSTATUS WINAPI LsaQueryInformationPolicy(
TRACE("setting Name to %s\n", debugstr_w(xdi->info.Name.Buffer));
}
- dwSize = MAX_COMPUTERNAME_LENGTH + 1;
+ dwSize = 256;
if (GetComputerNameExW(ComputerNameDnsDomain, xdi->dns_domain_name, &dwSize))
{
xdi->info.DnsDomainName.Buffer = xdi->dns_domain_name;
More information about the wine-cvs
mailing list