Zebediah Figura : msi: Avoid leaking memory on failure paths in MsiGetPropertyA().
Alexandre Julliard
julliard at winehq.org
Thu May 17 19:10:58 CDT 2018
Module: wine
Branch: master
Commit: 2e2934e455318c2753741a051876bc0a3c2399fa
URL: https://source.winehq.org/git/wine.git/?a=commit;h=2e2934e455318c2753741a051876bc0a3c2399fa
Author: Zebediah Figura <z.figura12 at gmail.com>
Date: Thu May 17 10:48:15 2018 -0500
msi: Avoid leaking memory on failure paths in MsiGetPropertyA().
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Hans Leidekker <hans at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/msi/package.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/dlls/msi/package.c b/dlls/msi/package.c
index ab6c3dd..2801efa 100644
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -2368,9 +2368,14 @@ UINT WINAPI MsiGetPropertyA(MSIHANDLE hinst, const char *name, char *buf, DWORD
DWORD len;
if (!(remote = msi_get_remote(hinst)))
+ {
+ heap_free(nameW);
return ERROR_INVALID_HANDLE;
+ }
r = remote_GetProperty(remote, nameW, &value, &len);
+ heap_free(nameW);
+
if (!r)
{
/* String might contain embedded nulls.
@@ -2388,7 +2393,6 @@ UINT WINAPI MsiGetPropertyA(MSIHANDLE hinst, const char *name, char *buf, DWORD
heap_free(tmp);
}
midl_user_free(value);
- heap_free(nameW);
return r;
}
More information about the wine-cvs
mailing list