Francois Gouget : testbot: Fix handling of test unit deletion + helper dll patch.

Alexandre Julliard julliard at winehq.org
Tue May 29 12:31:59 CDT 2018


Module: tools
Branch: master
Commit: 4bf681b11dfafa2dd7f9f769e957d0fa5b6b43ec
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=4bf681b11dfafa2dd7f9f769e957d0fa5b6b43ec

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue May 29 00:42:49 2018 +0200

testbot: Fix handling of test unit deletion + helper dll patch.

Take into account deleted test units when getting the full test unit
list.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/PatchUtils.pm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index 8dde61b..2000c90 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -218,12 +218,7 @@ sub GetPatchImpact($;$)
       # Helper dlls are not test units
       next if (exists $TestInfo->{Files}->{"$Base.spec"});
 
-      if ($AllUnits)
-      {
-        # All test units are impacted indirectly and must be rerun
-        $TestInfo->{Units}->{$Base} = 1;
-      }
-      elsif ($TestInfo->{Files}->{$File} and
+      if (($AllUnits or $TestInfo->{Files}->{$File}) and
              $TestInfo->{Files}->{$File} ne "rm")
       {
         # Only new/modified test units are impacted




More information about the wine-cvs mailing list