Francois Gouget : testbot/build: Fix handling of directory addition / removal.

Alexandre Julliard julliard at winehq.org
Wed May 30 14:29:49 CDT 2018


Module: tools
Branch: master
Commit: f9501a1f91a5e2a5da2649d1e74ca678c950d375
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=f9501a1f91a5e2a5da2649d1e74ca678c950d375

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed May 30 08:05:35 2018 +0200

testbot/build: Fix handling of directory addition / removal.

When a directory is added or removed we must re-run make_makefiles.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/PatchUtils.pm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index 6c72e16..a466df3 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -87,7 +87,16 @@ sub _AddTest($$$)
   }
 
   # Assume makefile modifications may break the build but not the tests
-  return if ($File eq "Makefile.in" or $Impacts->{NoUnits});
+  if ($File eq "Makefile.in")
+  {
+    if ($Change eq "new" or $Change eq "rm")
+    {
+      # This adds / removes a directory
+      $Impacts->{Makefiles} = 1;
+    }
+    return;
+  }
+  return if ($Impacts->{NoUnits});
 
   if (!$Tests->{$Module}->{Files})
   {




More information about the wine-cvs mailing list