Francois Gouget : testbot: Fix error checking on a Steps::Save() call.

Alexandre Julliard julliard at winehq.org
Wed May 30 14:29:49 CDT 2018


Module: tools
Branch: master
Commit: a0e2d911c1a47e910bab11fcd0137d3a33389f42
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=a0e2d911c1a47e910bab11fcd0137d3a33389f42

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed May 30 15:27:43 2018 +0200

testbot: Fix error checking on a Steps::Save() call.

Collection::Save() returns three values, unlike Item::Save() which only
returns two!

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/Jobs.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm
index 6be271b..ef0d98e 100644
--- a/testbot/lib/WineTestBot/Jobs.pm
+++ b/testbot/lib/WineTestBot/Jobs.pm
@@ -98,7 +98,7 @@ sub OnDelete($)
 
   my $Steps = $self->Steps;
   map { $_->PreviousNo(undef) } @{$Steps->GetItems()};
-  my ($_ErrProperty, $ErrMessage) = $Steps->Save();
+  my ($_ErrKey, $_ErrProperty, $ErrMessage) = $Steps->Save();
 
   return $ErrMessage || $self->SUPER::OnDelete();
 }




More information about the wine-cvs mailing list