Dmitry Timoshkov : server: Map FILE_NOTIFY_CHANGE_LAST_ACCESS to IN_MODIFY.

Alexandre Julliard julliard at winehq.org
Wed Nov 7 14:47:32 CST 2018


Module: wine
Branch: master
Commit: bfa98dbb1ba8db7c43a16ad520c65fcdc00c7769
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=bfa98dbb1ba8db7c43a16ad520c65fcdc00c7769

Author: Dmitry Timoshkov <dmitry at baikal.ru>
Date:   Tue Nov  6 17:05:56 2018 +0300

server: Map FILE_NOTIFY_CHANGE_LAST_ACCESS to IN_MODIFY.

Using IN_ACCESS leads to generating stray change notifications.

Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 server/change.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/server/change.c b/server/change.c
index 3335e7a..3dd52aa 100644
--- a/server/change.c
+++ b/server/change.c
@@ -742,11 +742,9 @@ static unsigned int filter_from_event( struct inotify_event *ie )
     if (ie->mask & (IN_MOVED_FROM | IN_MOVED_TO | IN_DELETE | IN_CREATE))
         filter |= FILE_NOTIFY_CHANGE_FILE_NAME | FILE_NOTIFY_CHANGE_DIR_NAME;
     if (ie->mask & IN_MODIFY)
-        filter |= FILE_NOTIFY_CHANGE_SIZE | FILE_NOTIFY_CHANGE_LAST_WRITE;
+        filter |= FILE_NOTIFY_CHANGE_SIZE | FILE_NOTIFY_CHANGE_LAST_WRITE | FILE_NOTIFY_CHANGE_LAST_ACCESS;
     if (ie->mask & IN_ATTRIB)
         filter |= FILE_NOTIFY_CHANGE_ATTRIBUTES | FILE_NOTIFY_CHANGE_SECURITY;
-    if (ie->mask & IN_ACCESS)
-        filter |= FILE_NOTIFY_CHANGE_LAST_ACCESS;
     if (ie->mask & IN_CREATE)
         filter |= FILE_NOTIFY_CHANGE_CREATION;
 
@@ -979,7 +977,7 @@ static int map_flags( unsigned int filter )
     if (filter & FILE_NOTIFY_CHANGE_LAST_WRITE)
         mask |= IN_MODIFY;
     if (filter & FILE_NOTIFY_CHANGE_LAST_ACCESS)
-        mask |= IN_ACCESS;
+        mask |= IN_MODIFY;
     if (filter & FILE_NOTIFY_CHANGE_SECURITY)
         mask |= IN_ATTRIB;
 




More information about the wine-cvs mailing list