Andreas Maier : dbghelp: Use correct record in codeview_snarf_public.
Alexandre Julliard
julliard at winehq.org
Mon Nov 26 16:20:10 CST 2018
Module: wine
Branch: master
Commit: dbcf9728fa13ade68cc9d380002a5f6ae50fc0c0
URL: https://source.winehq.org/git/wine.git/?a=commit;h=dbcf9728fa13ade68cc9d380002a5f6ae50fc0c0
Author: Andreas Maier <staubim at quantentunnel.de>
Date: Sun Nov 25 10:15:46 2018 +0100
dbghelp: Use correct record in codeview_snarf_public.
Use public_vx iststead of data_vx for public symbols.
Signed-off-by: Andreas Maier <staubim at quantentunnel.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/dbghelp/msc.c | 18 +++++++++---------
include/wine/mscvpdb.h | 10 ++++++++++
2 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c
index 493c440..ae51884 100644
--- a/dlls/dbghelp/msc.c
+++ b/dlls/dbghelp/msc.c
@@ -2067,29 +2067,29 @@ static BOOL codeview_snarf_public(const struct msc_debug_info* msc_dbg, const BY
switch (sym->generic.id)
{
- case S_PUB_V1: /* FIXME is this really a 'data_v1' structure ?? */
+ case S_PUB_V1:
if (!(dbghelp_options & SYMOPT_NO_PUBLICS))
{
symt_new_public(msc_dbg->module, compiland,
- terminate_string(&sym->data_v1.p_name),
- codeview_get_address(msc_dbg, sym->data_v1.segment, sym->data_v1.offset), 1);
+ terminate_string(&sym->public_v1.p_name),
+ codeview_get_address(msc_dbg, sym->public_v1.segment, sym->public_v1.offset), 1);
}
break;
- case S_PUB_V2: /* FIXME is this really a 'data_v2' structure ?? */
+ case S_PUB_V2:
if (!(dbghelp_options & SYMOPT_NO_PUBLICS))
{
symt_new_public(msc_dbg->module, compiland,
- terminate_string(&sym->data_v2.p_name),
- codeview_get_address(msc_dbg, sym->data_v2.segment, sym->data_v2.offset), 1);
+ terminate_string(&sym->public_v2.p_name),
+ codeview_get_address(msc_dbg, sym->public_v2.segment, sym->public_v2.offset), 1);
}
- break;
+ break;
case S_PUB_V3:
if (!(dbghelp_options & SYMOPT_NO_PUBLICS))
{
symt_new_public(msc_dbg->module, compiland,
- sym->data_v3.name,
- codeview_get_address(msc_dbg, sym->data_v3.segment, sym->data_v3.offset), 1);
+ sym->public_v3.name,
+ codeview_get_address(msc_dbg, sym->public_v3.segment, sym->public_v3.offset), 1);
}
break;
case S_PUB_FUNC1_V3:
diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h
index 2f0b479..7a4a69b 100644
--- a/include/wine/mscvpdb.h
+++ b/include/wine/mscvpdb.h
@@ -1352,6 +1352,16 @@ union codeview_symbol
{
short int len;
short int id;
+ unsigned int offset;
+ unsigned short segment;
+ unsigned short symtype;
+ struct p_string p_name;
+ } public_v1;
+
+ struct
+ {
+ short int len;
+ short int id;
unsigned int symtype;
unsigned int offset;
unsigned short segment;
More information about the wine-cvs
mailing list