Nikolay Sivov : opcservices: Improve error handling (Coverity).

Alexandre Julliard julliard at winehq.org
Wed Sep 19 16:28:12 CDT 2018


Module: wine
Branch: master
Commit: ab462acf4eaf92dcc254df97547d2bb970ee5ba2
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=ab462acf4eaf92dcc254df97547d2bb970ee5ba2

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Sep 19 14:19:35 2018 +0300

opcservices: Improve error handling (Coverity).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/opcservices/package.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/dlls/opcservices/package.c b/dlls/opcservices/package.c
index fab337d..c865cf3 100644
--- a/dlls/opcservices/package.c
+++ b/dlls/opcservices/package.c
@@ -1476,9 +1476,9 @@ static HRESULT opc_package_write_contenttypes(struct zip_archive *archive, IXmlW
     if (FAILED(hr = CreateStreamOnHGlobal(NULL, TRUE, &content)))
         return hr;
 
-    IXmlWriter_SetOutput(writer, (IUnknown *)content);
-
-    hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Omit);
+    hr = IXmlWriter_SetOutput(writer, (IUnknown *)content);
+    if (SUCCEEDED(hr))
+        hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Omit);
     if (SUCCEEDED(hr))
         hr = IXmlWriter_WriteStartElement(writer, NULL, typesW, uriW);
     if (SUCCEEDED(hr))
@@ -1566,9 +1566,9 @@ static HRESULT opc_package_write_rels(struct zip_archive *archive, IOpcRelations
         return hr;
     }
 
-    IXmlWriter_SetOutput(writer, (IUnknown *)content);
-
-    hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Yes);
+    hr = IXmlWriter_SetOutput(writer, (IUnknown *)content);
+    if (SUCCEEDED(hr))
+        hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Yes);
     if (SUCCEEDED(hr))
         hr = IXmlWriter_WriteStartElement(writer, NULL, relationshipsW, uriW);
 




More information about the wine-cvs mailing list