Alexandre Julliard : Revert "winebuild: Quote stdcall decored symbols."

Alexandre Julliard julliard at winehq.org
Tue Aug 27 03:45:10 CDT 2019


Module: wine
Branch: master
Commit: 0fd3b1eab96b19f320a626f0991f92257fa12556
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=0fd3b1eab96b19f320a626f0991f92257fa12556

Author: Alexandre Julliard <julliard at winehq.org>
Date:   Tue Aug 27 10:12:10 2019 +0200

Revert "winebuild: Quote stdcall decored symbols."

This reverts commit a3e1fe936edc076168571da8ab4320cae22f64d4.
It breaks with older binutils.

Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 tools/winebuild/spec16.c | 2 +-
 tools/winebuild/spec32.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/winebuild/spec16.c b/tools/winebuild/spec16.c
index d008aed..3a7e457 100644
--- a/tools/winebuild/spec16.c
+++ b/tools/winebuild/spec16.c
@@ -759,7 +759,7 @@ static void output_module16( DLLSPEC *spec )
         if (!odp || !is_function( odp )) continue;
         output( ".L__wine_%s_%u:\n", spec->c_name, i );
         output( "\tpushw %%bp\n" );
-        output( "\tpushl $\"%s\"\n",
+        output( "\tpushl $%s\n",
                 asm_name( odp->type == TYPE_STUB ? get_stub_name( odp, spec ) : get_link_name( odp )));
         output( "\tcallw .L__wine_spec_callfrom16_%s\n", get_callfrom16_name( odp ) );
     }
diff --git a/tools/winebuild/spec32.c b/tools/winebuild/spec32.c
index 727df53..f2567e8 100644
--- a/tools/winebuild/spec32.c
+++ b/tools/winebuild/spec32.c
@@ -570,7 +570,7 @@ void output_exports( DLLSPEC *spec )
                 output( "1:\tjmp *__imp_%s-1b(%%eax)\n", asm_name( get_link_name( odp )));
                 needs_get_pc_thunk = 1;
             }
-            else output( "\tjmp *\"__imp_%s\"\n", asm_name( get_link_name( odp )));
+            else output( "\tjmp *__imp_%s\n", asm_name( get_link_name( odp )));
             break;
         case CPU_x86_64:
             output( "\t.byte 0x48\n" );  /* hotpatch prolog */




More information about the wine-cvs mailing list