Francois Gouget : testbot/LogUtils: Fix GetNewLogErrors() when there are no errors.

Alexandre Julliard julliard at winehq.org
Thu Dec 5 15:42:12 CST 2019


Module: tools
Branch: master
Commit: d469942b22d626522a9316582294fb11d1a14f84
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=d469942b22d626522a9316582294fb11d1a14f84

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Dec  5 10:53:28 2019 +0100

testbot/LogUtils: Fix GetNewLogErrors() when there are no errors.

Don't use $Groups if it is undefined.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/LogUtils.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm
index 5193296..32bf0fa 100644
--- a/testbot/lib/WineTestBot/LogUtils.pm
+++ b/testbot/lib/WineTestBot/LogUtils.pm
@@ -889,7 +889,7 @@ sub GetNewLogErrors($$$)
   my ($RefFileName, $Groups, $Errors) = @_;
 
   my (@NewGroups, %NewErrors, %NewIndices);
-  return (\@NewGroups, \%NewErrors, \%NewIndices) if (!@$Groups);
+  return (\@NewGroups, \%NewErrors, \%NewIndices) if (!$Groups or !@$Groups);
 
   my ($RefGroups, $RefErrors) = GetLogErrors($RefFileName);
   return (undef, undef) if (!$RefGroups);




More information about the wine-cvs mailing list