Francois Gouget : testbot/WineSendLog: Errors are not new when missing reference reports.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 84ecff2af7c128f3fe6cdd3b9ef26ff255cc72d7
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=84ecff2af7c128f3fe6cdd3b9ef26ff255cc72d7

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Dec  5 13:23:04 2019 +0100

testbot/WineSendLog: Errors are not new when missing reference reports.

Build logs don't have reference logs so for them every error is new.
But test reports should have reference WineTest results and if not
reporting the errors as new would cause false positives. So default
to "not new" in that case.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/bin/WineSendLog.pl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index 721122e..95cc036 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -291,8 +291,11 @@ EOF
       my ($NewGroups, $NewErrors, $_NewIndices) = GetNewLogErrors($RefFileName, $LogErrors->{Groups}, $LogErrors->{Errors});
       if (!$NewGroups)
       {
-        # There was no reference log (typical of build logs)
-        # so every error is new
+        # Test reports should have reference WineTest results and if not
+        # reporting the errors as new would cause false positives.
+        next if ($LogName =~ /\.report$/);
+
+        # Build logs don't have reference logs so for them every error is new.
         $NewGroups = $LogErrors->{Groups};
         $NewErrors = $LogErrors->{Errors};
       }