Francois Gouget : user32/tests: Avoid an unneeded (&commented out) strlen() call.
Alexandre Julliard
julliard at winehq.org
Mon Dec 9 16:57:37 CST 2019
Module: wine
Branch: master
Commit: e248170e30d9103e3ff162efc5eb91a8723b18ee
URL: https://source.winehq.org/git/wine.git/?a=commit;h=e248170e30d9103e3ff162efc5eb91a8723b18ee
Author: Francois Gouget <fgouget at free.fr>
Date: Mon Dec 9 09:40:06 2019 +0100
user32/tests: Avoid an unneeded (&commented out) strlen() call.
Note that pathBuffer is an array and thus cannot be NULL.
Signed-off-by: Francois Gouget <fgouget at free.fr>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/user32/tests/listbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/user32/tests/listbox.c b/dlls/user32/tests/listbox.c
index 8d8115131e..9f6f45990f 100644
--- a/dlls/user32/tests/listbox.c
+++ b/dlls/user32/tests/listbox.c
@@ -1710,7 +1710,7 @@ static void test_listbox_dlgdir(void)
ok (res == 0, "DlgDirSelectEx() with no selection returned %d, expected 0\n", res);
/* WinXP-SP2 leaves pathBuffer untouched, but Win98 fills it with garbage. */
/*
- ok (strlen(pathBuffer) == 0, "DlgDirSelectEx() with no selection filled buffer with %s\n", pathBuffer);
+ ok (!*pathBuffer, "DlgDirSelectEx() with no selection filled buffer with %s\n", pathBuffer);
*/
/* Test proper drive/dir/file recognition */
itemCount = SendMessageA(g_listBox, LB_GETCOUNT, 0, 0);
More information about the wine-cvs
mailing list