Austin English : httpapi: Return ERROR_SUCCESS for unimplemented flags in HttpInitialize.

Alexandre Julliard julliard at winehq.org
Mon Dec 9 16:57:38 CST 2019


Module: wine
Branch: master
Commit: 280bfb58b5162be6d8cee8827307721d7624ac0d
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=280bfb58b5162be6d8cee8827307721d7624ac0d

Author: Austin English <austinenglish at gmail.com>
Date:   Sun Dec  8 23:11:27 2019 -0600

httpapi: Return ERROR_SUCCESS for unimplemented flags in HttpInitialize.

Returning ERROR_CALL_NOT_IMPLEMENTED breaks .Net installers. MSDN suggests
that ERROR_INVALID_PARAMETER may be more appropriate, but that too breaks .Net.

Signed-off-by: Austin English <austinenglish at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/httpapi/httpapi_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/httpapi/httpapi_main.c b/dlls/httpapi/httpapi_main.c
index 0449d53045..8adbd38be5 100644
--- a/dlls/httpapi/httpapi_main.c
+++ b/dlls/httpapi/httpapi_main.c
@@ -62,7 +62,7 @@ ULONG WINAPI HttpInitialize(HTTPAPI_VERSION version, ULONG flags, void *reserved
     if (flags & ~HTTP_INITIALIZE_SERVER)
     {
         FIXME("Unhandled flags %#x.\n", flags);
-        return ERROR_CALL_NOT_IMPLEMENTED;
+        return ERROR_SUCCESS;
     }
 
     if (!(manager = OpenSCManagerW(NULL, NULL, SC_MANAGER_CONNECT)))




More information about the wine-cvs mailing list