Francois Gouget : winecfg: Avoid an unneeded strlen() call.

Alexandre Julliard julliard at winehq.org
Tue Dec 10 15:58:50 CST 2019


Module: wine
Branch: master
Commit: 81d5d929ba5e5c570274173ebdc06892b54fa5bf
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=81d5d929ba5e5c570274173ebdc06892b54fa5bf

Author: Francois Gouget <fgouget at free.fr>
Date:   Tue Dec 10 09:36:31 2019 +0100

winecfg: Avoid an unneeded strlen() call.

Note that szLinkTarget is an array field and thus cannot be NULL.

Signed-off-by: Francois Gouget <fgouget at free.fr>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 programs/winecfg/theme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/winecfg/theme.c b/programs/winecfg/theme.c
index 66d23448f6..dffe1861e8 100644
--- a/programs/winecfg/theme.c
+++ b/programs/winecfg/theme.c
@@ -842,7 +842,7 @@ static void on_shell_folder_selection_changed(HWND hDlg, LPNMLISTVIEW lpnm) {
     if (lpnm->uNewState & LVIS_SELECTED) {
         psfiSelected = (struct ShellFolderInfo *)lpnm->lParam;
         EnableWindow(GetDlgItem(hDlg, IDC_LINK_SFPATH), 1);
-        if (strlen(psfiSelected->szLinkTarget)) {
+        if (*psfiSelected->szLinkTarget) {
             WCHAR *link;
             CheckDlgButton(hDlg, IDC_LINK_SFPATH, BST_CHECKED);
             EnableWindow(GetDlgItem(hDlg, IDC_EDIT_SFPATH), 1);




More information about the wine-cvs mailing list