=?UTF-8?Q?J=C3=B3zef=20Kucia=20?=: d3d8: Clamp index buffer upload range to buffer size.
Alexandre Julliard
julliard at winehq.org
Wed Jan 16 16:25:00 CST 2019
Module: wine
Branch: master
Commit: a2829a6529ba67e7bf2c8e834b939e30cb2a3cca
URL: https://source.winehq.org/git/wine.git/?a=commit;h=a2829a6529ba67e7bf2c8e834b939e30cb2a3cca
Author: Józef Kucia <jkucia at codeweavers.com>
Date: Tue Jan 15 15:28:00 2019 +0100
d3d8: Clamp index buffer upload range to buffer size.
Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/d3d8/device.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c
index 9e82b1e..1d892ec 100644
--- a/dlls/d3d8/device.c
+++ b/dlls/d3d8/device.c
@@ -2301,8 +2301,10 @@ static void d3d8_device_upload_sysmem_index_buffer(struct d3d8_device *device,
unsigned int start_idx, unsigned int idx_count)
{
struct wined3d_box box = {0, 0, 0, 1, 0, 1};
- struct d3d8_vertexbuffer *d3d8_buffer;
+ struct wined3d_resource *dst_resource;
+ struct d3d8_indexbuffer *d3d8_buffer;
struct wined3d_buffer *dst_buffer;
+ struct wined3d_resource_desc desc;
enum wined3d_format_id format;
unsigned int offset, idx_size;
HRESULT hr;
@@ -2313,11 +2315,13 @@ static void d3d8_device_upload_sysmem_index_buffer(struct d3d8_device *device,
if (!(dst_buffer = wined3d_device_get_index_buffer(device->wined3d_device, &format, &offset)))
ERR("Failed to get index buffer.\n");
d3d8_buffer = wined3d_buffer_get_parent(dst_buffer);
+ dst_resource = wined3d_buffer_get_resource(dst_buffer);
+ wined3d_resource_get_desc(dst_resource, &desc);
idx_size = format == WINED3DFMT_R16_UINT ? 2 : 4;
box.left = offset + start_idx * idx_size;
- box.right = box.left + idx_count * idx_size;
+ box.right = min(box.left + idx_count * idx_size, desc.size);
if (FAILED(hr = wined3d_device_copy_sub_resource_region(device->wined3d_device,
- wined3d_buffer_get_resource(dst_buffer), 0, box.left, 0, 0,
+ dst_resource, 0, box.left, 0, 0,
wined3d_buffer_get_resource(d3d8_buffer->wined3d_buffer), 0, &box, 0)))
ERR("Failed to update buffer.\n");
}
More information about the wine-cvs
mailing list