Zebediah Figura : msi: Remove an unnecessary call to SELECT_get_dimensions ().

Alexandre Julliard julliard at winehq.org
Mon Jan 28 16:16:59 CST 2019


Module: wine
Branch: master
Commit: 7728acd1b6994c553a046e3ff9ee1aebc20c38b6
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=7728acd1b6994c553a046e3ff9ee1aebc20c38b6

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Sat Jan 26 16:59:00 2019 -0600

msi: Remove an unnecessary call to SELECT_get_dimensions().

Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Hans Leidekker <hans at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/msi/select.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/dlls/msi/select.c b/dlls/msi/select.c
index 99339c2..c6e7b20 100644
--- a/dlls/msi/select.c
+++ b/dlls/msi/select.c
@@ -233,14 +233,10 @@ static UINT SELECT_get_column_info( struct tagMSIVIEW *view, UINT n, LPCWSTR *na
 static UINT msi_select_update(struct tagMSIVIEW *view, MSIRECORD *rec, UINT row)
 {
     MSISELECTVIEW *sv = (MSISELECTVIEW*)view;
-    UINT r, i, num_columns, col, type, val;
+    UINT r, i, col, type, val;
     LPCWSTR str;
 
-    r = SELECT_get_dimensions(view, NULL, &num_columns);
-    if (r != ERROR_SUCCESS)
-        return r;
-
-    for (i = 0; i < num_columns; i++)
+    for (i = 0; i < sv->num_cols; i++)
     {
         col = sv->cols[i];
 




More information about the wine-cvs mailing list