Zebediah Figura : ntdll: Correctly fill DataTransferLength in SCSI_PASS_THROUGH and SCSI_PASS_THROUGH_DIRECT.

Alexandre Julliard julliard at winehq.org
Tue Jul 2 15:32:01 CDT 2019


Module: wine
Branch: master
Commit: bf891f34af32839bf949e7ca4a1921754aa5e0d1
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=bf891f34af32839bf949e7ca4a1921754aa5e0d1

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Mon Jul  1 19:03:14 2019 -0500

ntdll: Correctly fill DataTransferLength in SCSI_PASS_THROUGH and SCSI_PASS_THROUGH_DIRECT.

DataTransferLength specifies the number of bytes transferred, but
sg_io_hdr_t.resid gives the number of bytes *not* transferred:
https://www.tldp.org/HOWTO/SCSI-Generic-HOWTO/x356.html

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47424
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ntdll/cdrom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c
index 4a3b84d..f6e3a86 100644
--- a/dlls/ntdll/cdrom.c
+++ b/dlls/ntdll/cdrom.c
@@ -1658,7 +1658,7 @@ static NTSTATUS CDROM_ScsiPassThroughDirect(int fd, PSCSI_PASS_THROUGH_DIRECT pP
     io = ioctl(fd, SG_IO, &cmd);
 
     pPacket->ScsiStatus         = cmd.status;
-    pPacket->DataTransferLength = cmd.resid;
+    pPacket->DataTransferLength -= cmd.resid;
     pPacket->SenseInfoLength    = cmd.sb_len_wr;
 
     ret = CDROM_GetStatusCode(io);
@@ -1842,7 +1842,7 @@ static NTSTATUS CDROM_ScsiPassThrough(int fd, PSCSI_PASS_THROUGH pPacket)
     io = ioctl(fd, SG_IO, &cmd);
 
     pPacket->ScsiStatus         = cmd.status;
-    pPacket->DataTransferLength = cmd.resid;
+    pPacket->DataTransferLength -= cmd.resid;
     pPacket->SenseInfoLength    = cmd.sb_len_wr;
 
     ret = CDROM_GetStatusCode(io);




More information about the wine-cvs mailing list