Paul Gofman : wined3d: Scale transformed position in compute_light().

Alexandre Julliard julliard at winehq.org
Tue Jun 4 16:28:13 CDT 2019


Module: wine
Branch: master
Commit: b577999918baa8718b8ddb5dfe27e9df397a320d
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=b577999918baa8718b8ddb5dfe27e9df397a320d

Author: Paul Gofman <gofmanp at gmail.com>
Date:   Wed May 22 12:39:25 2019 +0300

wined3d: Scale transformed position in compute_light().

Signed-off-by: Paul Gofman <gofmanp at gmail.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/wined3d/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index 702fda2..d8dacde 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -3436,8 +3436,8 @@ static void compute_light(struct wined3d_color *ambient, struct wined3d_color *d
     float att;
 
     wined3d_vec4_transform(&position_transformed, position, &ls->modelview_matrix);
+    wined3d_vec3_scale((struct wined3d_vec3 *)&position_transformed, 1.0f / position_transformed.w);
     position_transformed_normalised = *(const struct wined3d_vec3 *)&position_transformed;
-    wined3d_vec3_scale(&position_transformed_normalised, 1.0f / position_transformed.w);
     wined3d_vec3_normalise(&position_transformed_normalised);
 
     if (normal)




More information about the wine-cvs mailing list