Dmitry Timoshkov : mshtml: Replace a useless trace with a slightly better one.

Alexandre Julliard julliard at winehq.org
Tue Jun 18 17:21:47 CDT 2019


Module: wine
Branch: master
Commit: 2348215b82d1c0019a0cdcee79cb2a5aaa34e345
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=2348215b82d1c0019a0cdcee79cb2a5aaa34e345

Author: Dmitry Timoshkov <dmitry at baikal.ru>
Date:   Tue Jun 18 14:09:59 2019 +0800

mshtml: Replace a useless trace with a slightly better one.

Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/dispex.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c
index f0daafa..dab4499 100644
--- a/dlls/mshtml/dispex.c
+++ b/dlls/mshtml/dispex.c
@@ -256,8 +256,10 @@ static void add_func_info(dispex_data_t *data, tid_t tid, const FUNCDESC *desc,
     HRESULT hres;
 
     hres = ITypeInfo_GetDocumentation(dti, desc->memid, &name, NULL, NULL, NULL);
-    if(FAILED(hres))
+    if(FAILED(hres)) {
+        WARN("GetDocumentation failed: %08x\n", hres);
         return;
+    }
 
     for(info = data->funcs; info < data->funcs+data->func_cnt; info++) {
         if(info->id == desc->memid || !wcscmp(info->name, name)) {
@@ -269,6 +271,8 @@ static void add_func_info(dispex_data_t *data, tid_t tid, const FUNCDESC *desc,
         }
     }
 
+    TRACE("adding %s...\n", debugstr_w(name));
+
     if(info == data->funcs+data->func_cnt) {
         if(data->func_cnt == data->func_size)
             data->funcs = heap_realloc_zero(data->funcs, (data->func_size <<= 1)*sizeof(func_info_t));
@@ -414,7 +418,6 @@ static HRESULT process_interface(dispex_data_t *data, tid_t tid, ITypeInfo *disp
         }
 
         if(!hook || hook->invoke) {
-            TRACE("adding...\n");
             add_func_info(data, tid, funcdesc, disp_typeinfo ? disp_typeinfo : typeinfo,
                           hook ? hook->invoke : NULL);
         }




More information about the wine-cvs mailing list