Alistair Leslie-Hughes : oleaut32: Add missing return value checks ( Coverity).

Alexandre Julliard julliard at winehq.org
Mon Mar 4 15:08:27 CST 2019


Module: wine
Branch: master
Commit: 4a6f002d9ad7b1b75922436151843054ce281e86
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=4a6f002d9ad7b1b75922436151843054ce281e86

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Sun Mar  3 22:05:18 2019 +0000

oleaut32: Add missing return value checks (Coverity).

CID 1442938:  Error handling issues  (CHECKED_RETURN)

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/oleaut32/variant.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/oleaut32/variant.c b/dlls/oleaut32/variant.c
index fcbef53..77e48c0 100644
--- a/dlls/oleaut32/variant.c
+++ b/dlls/oleaut32/variant.c
@@ -5138,7 +5138,9 @@ HRESULT WINAPI VarRound(LPVARIANT pVarIn, int deci, LPVARIANT pVarOut)
     {
         double dbl;
 
-        VarR8FromDec(&V_DECIMAL(pVarIn), &dbl);
+        hRet = VarR8FromDec(&V_DECIMAL(pVarIn), &dbl);
+        if (FAILED(hRet))
+            break;
 
         if (dbl>0.0f)
             dbl = floor(dbl*pow(10,deci)+0.5);
@@ -5146,7 +5148,7 @@ HRESULT WINAPI VarRound(LPVARIANT pVarIn, int deci, LPVARIANT pVarOut)
             dbl = ceil(dbl*pow(10,deci)-0.5);
 
         V_VT(pVarOut)=VT_DECIMAL;
-        VarDecFromR8(dbl, &V_DECIMAL(pVarOut));
+        hRet = VarDecFromR8(dbl, &V_DECIMAL(pVarOut));
         break;
     }
     /* cases we don't know yet */




More information about the wine-cvs mailing list