=?UTF-8?Q?J=C3=B3zef=20Kucia=20?=: setupapi: Avoid debugstr buffer overflow.

Alexandre Julliard julliard at winehq.org
Mon May 13 16:24:16 CDT 2019


Module: wine
Branch: master
Commit: 88e28d971bd119f214e29d4ebfa819af9f18f5b7
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=88e28d971bd119f214e29d4ebfa819af9f18f5b7

Author: Józef Kucia <jkucia at codeweavers.com>
Date:   Sun May 12 15:50:09 2019 +0200

setupapi: Avoid debugstr buffer overflow.

Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/setupapi/parser.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/dlls/setupapi/parser.c b/dlls/setupapi/parser.c
index c108689..69376c4 100644
--- a/dlls/setupapi/parser.c
+++ b/dlls/setupapi/parser.c
@@ -1853,13 +1853,8 @@ BOOL WINAPI SetupGetBinaryField( PINFCONTEXT context, DWORD index, BYTE *buffer,
         }
         buffer[i - index] = value;
     }
-    if (TRACE_ON(setupapi))
-    {
-        TRACE( "%p/%p/%d/%d index %d returning",
-               context->Inf, context->CurrentInf, context->Section, context->Line, index );
-        for (i = index; i < line->nb_fields; i++) TRACE( " %02x", buffer[i - index] );
-        TRACE( "\n" );
-    }
+    TRACE( "%p/%p/%d/%d index %d\n",
+           context->Inf, context->CurrentInf, context->Section, context->Line, index );
     return TRUE;
 }
 




More information about the wine-cvs mailing list