Sven Baars : mstask: Move memory allocation to avoid a memory leak ( Valgrind).

Alexandre Julliard julliard at winehq.org
Wed May 15 14:32:23 CDT 2019


Module: wine
Branch: stable
Commit: c9dad2c6ce96539d487b5a27f3bcd72dd725ad92
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=c9dad2c6ce96539d487b5a27f3bcd72dd725ad92

Author: Sven Baars <sven.wine at gmail.com>
Date:   Wed Feb  6 11:48:19 2019 +0100

mstask: Move memory allocation to avoid a memory leak (Valgrind).

Signed-off-by: Sven Baars <sven.wine at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
(cherry picked from commit e4f15a297f301bb3c484a827a152e5f10184ff61)
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>

---

 dlls/mstask/task_scheduler.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/mstask/task_scheduler.c b/dlls/mstask/task_scheduler.c
index 7998b3a..ebf25d0 100644
--- a/dlls/mstask/task_scheduler.c
+++ b/dlls/mstask/task_scheduler.c
@@ -143,10 +143,6 @@ static HRESULT WINAPI EnumWorkItems_Next(IEnumWorkItems *iface, ULONG count, LPW
     enumerated = 0;
     list = NULL;
 
-    allocated = 64;
-    list = CoTaskMemAlloc(allocated * sizeof(list[0]));
-    if (!list) return E_OUTOFMEMORY;
-
     if (This->handle == INVALID_HANDLE_VALUE)
     {
         GetWindowsDirectoryW(path, MAX_PATH);
@@ -161,6 +157,10 @@ static HRESULT WINAPI EnumWorkItems_Next(IEnumWorkItems *iface, ULONG count, LPW
             return S_FALSE;
     }
 
+    allocated = 64;
+    list = CoTaskMemAlloc(allocated * sizeof(list[0]));
+    if (!list) return E_OUTOFMEMORY;
+
     do
     {
         if (is_file(&data))




More information about the wine-cvs mailing list