Zebediah Figura : qedit/nullrenderer: Use strmbase_renderer_cleanup().

Alexandre Julliard julliard at winehq.org
Thu May 16 16:26:56 CDT 2019


Module: wine
Branch: master
Commit: 3855216cb3830aa4e6d73c66c19fdc330f14c4df
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=3855216cb3830aa4e6d73c66c19fdc330f14c4df

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Wed May 15 18:16:59 2019 -0500

qedit/nullrenderer: Use strmbase_renderer_cleanup().

Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/qedit/nullrenderer.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/dlls/qedit/nullrenderer.c b/dlls/qedit/nullrenderer.c
index c19a90d..6ba70cb 100644
--- a/dlls/qedit/nullrenderer.c
+++ b/dlls/qedit/nullrenderer.c
@@ -113,11 +113,12 @@ static ULONG WINAPI NullRendererInner_AddRef(IUnknown *iface)
 static ULONG WINAPI NullRendererInner_Release(IUnknown *iface)
 {
     NullRendererImpl *This = impl_from_IUnknown(iface);
-    ULONG refCount = BaseRendererImpl_Release(&This->renderer.filter.IBaseFilter_iface);
+    ULONG refCount = InterlockedDecrement(&This->renderer.filter.refCount);
 
     if (!refCount)
     {
         TRACE("Destroying Null Renderer\n");
+        strmbase_renderer_cleanup(&This->renderer);
         CoTaskMemFree(This);
     }
 
@@ -234,10 +235,7 @@ HRESULT NullRenderer_create(IUnknown *pUnkOuter, void **ppv)
             (DWORD_PTR)(__FILE__ ": NullRendererImpl.csFilter"), &RendererFuncTable);
 
     if (FAILED(hr))
-    {
-        BaseRendererImpl_Release(&pNullRenderer->renderer.filter.IBaseFilter_iface);
         CoTaskMemFree(pNullRenderer);
-    }
     else
         *ppv = &pNullRenderer->IUnknown_inner;
 




More information about the wine-cvs mailing list