Zebediah Figura : qedit/mediadet: Check for failure from IEnumPins::Next().
Alexandre Julliard
julliard at winehq.org
Fri Nov 1 15:37:47 CDT 2019
Module: wine
Branch: master
Commit: 9defa529fcc98dad5387a0a6c2a7ea40a8966808
URL: https://source.winehq.org/git/wine.git/?a=commit;h=9defa529fcc98dad5387a0a6c2a7ea40a8966808
Author: Zebediah Figura <z.figura12 at gmail.com>
Date: Thu Oct 31 23:33:32 2019 -0500
qedit/mediadet: Check for failure from IEnumPins::Next().
Fixes a test crash when gstreamer is not present.
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/qedit/mediadet.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c
index b7a5abb80c..1d70a86a5a 100644
--- a/dlls/qedit/mediadet.c
+++ b/dlls/qedit/mediadet.c
@@ -456,7 +456,12 @@ static HRESULT GetSplitter(MediaDetImpl *This)
IPin_Release(source_pin);
goto retry;
}
- IEnumPins_Next(pins, 1, &splitter_pin, NULL);
+ if (IEnumPins_Next(pins, 1, &splitter_pin, NULL) != S_OK)
+ {
+ IEnumPins_Release(pins);
+ IPin_Release(source_pin);
+ goto retry;
+ }
IEnumPins_Release(pins);
hr = IPin_Connect(source_pin, splitter_pin, NULL);
More information about the wine-cvs
mailing list