Piotr Caban : msvcrt: Move more printf tests to table.

Alexandre Julliard julliard at winehq.org
Fri Nov 1 15:37:47 CDT 2019


Module: wine
Branch: master
Commit: 3798c0c4c92e588d8c217fbfb8b753eaa96c800d
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=3798c0c4c92e588d8c217fbfb8b753eaa96c800d

Author: Piotr Caban <piotr at codeweavers.com>
Date:   Fri Nov  1 11:49:38 2019 +0100

msvcrt: Move more printf tests to table.

Signed-off-by: Piotr Caban <piotr at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/msvcrt/tests/printf.c | 35 ++++++++++-------------------------
 1 file changed, 10 insertions(+), 25 deletions(-)

diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c
index d62f09cc0f..bfdab8cc6b 100644
--- a/dlls/msvcrt/tests/printf.c
+++ b/dlls/msvcrt/tests/printf.c
@@ -242,6 +242,8 @@ static void test_sprintf( void )
         { "%C", "a", 0, INT_ARG, 'a' },
         { "%C", "", 0, INT_ARG, 0x3042 },
         { "a%Cb", "ab", 0, INT_ARG, 0x3042 },
+        { "%lld", "-8589934591", "1", ULONGLONG_ARG, 0, ((ULONGLONG)0xffffffff)*0xffffffff },
+        { "%I32d", "1", "I32d", INT_ARG, 1 }
     };
 
     char buffer[100];
@@ -278,19 +280,6 @@ static void test_sprintf( void )
         }
     }
 
-    r = p_sprintf(buffer, "%lld", ((ULONGLONG)0xffffffff)*0xffffffff);
-    ok( r == 1 || r == 11, "return count wrong %d\n", r);
-    if (r == 11)  /* %ll works on Vista */
-        ok(!strcmp(buffer, "-8589934591"), "Problem with \"ll\" interpretation '%s'\n", buffer);
-    else
-        ok(!strcmp(buffer, "1"), "Problem with \"ll\" interpretation '%s'\n", buffer);
-
-    r = p_sprintf(buffer, "%I32d", 1);
-    if (r == 1)
-        ok(!strcmp(buffer,"1"),"I32d failed, got '%s'\n",buffer);
-    else
-        ok(r == 4 && !strcmp(buffer,"I32d"),"I32d failed, got '%s',%d\n",buffer,r);
-
     if (sizeof(void *) == 8)
     {
         r = p_sprintf(buffer, "%p", (void *)57);
@@ -316,6 +305,10 @@ static void test_sprintf( void )
         r = p_sprintf(buffer, "%Ix %d", (size_t)0x12345678123456,1);
         ok(!strcmp(buffer,"12345678123456 1"),"buffer = %s\n",buffer);
         ok( r==16, "return count wrong\n");
+
+        r = p_sprintf(buffer, "%p", 0);
+        ok(!strcmp(buffer,"0000000000000000"), "failed\n");
+        ok( r==16, "return count wrong\n");
     }
     else
     {
@@ -342,6 +335,10 @@ static void test_sprintf( void )
         r = p_sprintf(buffer, "%Ix %d", 0x123456, 1);
         ok(!strcmp(buffer,"123456 1"),"buffer = %s\n",buffer);
         ok( r==8, "return count wrong\n");
+
+        r = p_sprintf(buffer, "%p", 0);
+        ok(!strcmp(buffer,"00000000"), "failed\n");
+        ok( r==8, "return count wrong\n");
     }
 
     r = p_sprintf(buffer, "%.*s", 1, "foo");
@@ -367,18 +364,6 @@ static void test_sprintf( void )
         ok( r==4, "return count wrong: %d\n", r);
     }
 
-    r = p_sprintf(buffer, "%p", 0);
-    if (sizeof(void *) == 8)
-    {
-        ok(!strcmp(buffer,"0000000000000000"), "failed\n");
-        ok( r==16, "return count wrong\n");
-    }
-    else
-    {
-        ok(!strcmp(buffer,"00000000"), "failed\n");
-        ok( r==8, "return count wrong\n");
-    }
-
     r = p_sprintf(buffer, "%S", L"\x3042");
     ok(r==-1 || broken(!r), "r = %d\n", r);
 




More information about the wine-cvs mailing list