Michael Stefaniuc : vbscript: Remove redundant NULL checks before SysFreeString().

Alexandre Julliard julliard at winehq.org
Fri Nov 8 17:25:26 CST 2019


Module: wine
Branch: master
Commit: 8b7e38c542d0939c3f8cbd6d7c3d417fa801e1dc
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=8b7e38c542d0939c3f8cbd6d7c3d417fa801e1dc

Author: Michael Stefaniuc <mstefani at winehq.org>
Date:   Fri Nov  8 21:07:09 2019 +0100

vbscript: Remove redundant NULL checks before SysFreeString().

Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/vbscript/global.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c
index 8d4150ad70..a4442960d9 100644
--- a/dlls/vbscript/global.c
+++ b/dlls/vbscript/global.c
@@ -2948,19 +2948,19 @@ static HRESULT Err_Raise(BuiltinDisp *This, VARIANT *args, unsigned args_cnt, VA
         error = (code & ~0xffff) ? map_hres(code) : MAKE_VBSERROR(code);
 
         if(source) {
-            if(ctx->ei.bstrSource) SysFreeString(ctx->ei.bstrSource);
+            SysFreeString(ctx->ei.bstrSource);
             ctx->ei.bstrSource = source;
         }
         if(!ctx->ei.bstrSource)
             ctx->ei.bstrSource = get_vbscript_string(VBS_RUNTIME_ERROR);
         if(description) {
-            if(ctx->ei.bstrDescription) SysFreeString(ctx->ei.bstrDescription);
+            SysFreeString(ctx->ei.bstrDescription);
             ctx->ei.bstrDescription = description;
         }
         if(!ctx->ei.bstrDescription)
             ctx->ei.bstrDescription = get_vbscript_error_string(error);
         if(helpfile) {
-            if(ctx->ei.bstrHelpFile) SysFreeString(ctx->ei.bstrHelpFile);
+            SysFreeString(ctx->ei.bstrHelpFile);
             ctx->ei.bstrHelpFile = helpfile;
         }
         if(args_cnt >= 5)




More information about the wine-cvs mailing list