Hans-Kristian Arntzen : vkd3d: Do not use RESET_COMMAND_BUFFERS_BIT.
Alexandre Julliard
julliard at winehq.org
Tue Oct 1 15:42:41 CDT 2019
Module: vkd3d
Branch: master
Commit: a0ebcce39863a9d72930d0ecffa783782375c8a7
URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=a0ebcce39863a9d72930d0ecffa783782375c8a7
Author: Hans-Kristian Arntzen <post at arntzen-software.no>
Date: Tue Oct 1 16:01:55 2019 +0200
vkd3d: Do not use RESET_COMMAND_BUFFERS_BIT.
By setting this flag, command pools cannot efficiently pool allocations.
This flag should be set to 0 so only the VkCommandPool may be reset.
This matches D3D12 API.
Signed-off-by: Hans-Kristian Arntzen <post at arntzen-software.no>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
libs/vkd3d/command.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c
index 2d6d02d..d420863 100644
--- a/libs/vkd3d/command.c
+++ b/libs/vkd3d/command.c
@@ -1723,7 +1723,10 @@ static HRESULT d3d12_command_allocator_init(struct d3d12_command_allocator *allo
command_pool_info.sType = VK_STRUCTURE_TYPE_COMMAND_POOL_CREATE_INFO;
command_pool_info.pNext = NULL;
- command_pool_info.flags = VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT;
+ /* Do not use RESET_COMMAND_BUFFER_BIT. This allows the CommandPool to be a D3D12-style command pool.
+ * Memory is owned by the pool and CommandBuffers become lightweight handles,
+ * assuming a half-decent driver implementation. */
+ command_pool_info.flags = 0;
command_pool_info.queueFamilyIndex = queue->vk_family_index;
if ((vr = VK_CALL(vkCreateCommandPool(device->vk_device, &command_pool_info, NULL,
More information about the wine-cvs
mailing list