Vincent Povirk : windowscodecs/tests: Expect success from IWICStream_Commit.

Alexandre Julliard julliard at winehq.org
Mon Oct 21 15:28:39 CDT 2019


Module: wine
Branch: master
Commit: f704c36568fff2b925960034522c208353031986
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=f704c36568fff2b925960034522c208353031986

Author: Vincent Povirk <vincent at codeweavers.com>
Date:   Mon Oct 21 13:43:49 2019 -0500

windowscodecs/tests: Expect success from IWICStream_Commit.

Windows 10 implemented this.

Signed-off-by: Vincent Povirk <vincent at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/windowscodecs/tests/stream.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/dlls/windowscodecs/tests/stream.c b/dlls/windowscodecs/tests/stream.c
index 048f1326be..ef0d630c8e 100644
--- a/dlls/windowscodecs/tests/stream.c
+++ b/dlls/windowscodecs/tests/stream.c
@@ -326,19 +326,19 @@ static void test_StreamOnMemory(void)
 
     /* Commit */
     hr = IWICStream_Commit(pStream, STGC_DEFAULT);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pStream, STGC_OVERWRITE);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pStream, STGC_ONLYIFCURRENT);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pStream, STGC_DANGEROUSLYCOMMITMERELYTODISKCACHE);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pStream, STGC_CONSOLIDATE);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
 
     /* Revert */
@@ -643,19 +643,19 @@ static void test_StreamOnStreamRange(void)
 
     /* Commit */
     hr = IWICStream_Commit(pSubStream, STGC_DEFAULT);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pSubStream, STGC_OVERWRITE);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pSubStream, STGC_ONLYIFCURRENT);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pSubStream, STGC_DANGEROUSLYCOMMITMERELYTODISKCACHE);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(pSubStream, STGC_CONSOLIDATE);
-    ok(hr == E_NOTIMPL, "Commit returned %#x, expected %#x\n", hr, E_NOTIMPL);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
 
     /* Revert */
@@ -953,19 +953,19 @@ static void test_StreamOnIStream(void)
 
     /* Commit */
     hr = IWICStream_Commit(substream, STGC_DEFAULT);
-    ok(hr == E_NOTIMPL, "Unexpected hr %#x.\n", hr);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(substream, STGC_OVERWRITE);
-    ok(hr == E_NOTIMPL, "Unexpected hr %#x.\n", hr);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(substream, STGC_ONLYIFCURRENT);
-    ok(hr == E_NOTIMPL, "Unexpected hr %#x.\n", hr);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(substream, STGC_DANGEROUSLYCOMMITMERELYTODISKCACHE);
-    ok(hr == E_NOTIMPL, "Unexpected hr %#x.\n", hr);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     hr = IWICStream_Commit(substream, STGC_CONSOLIDATE);
-    ok(hr == E_NOTIMPL, "Unexpected hr %#x.\n", hr);
+    todo_wine ok(broken(hr == E_NOTIMPL) || hr == S_OK, "Commit returned %#x\n", hr);
 
     /* Revert */
     IWICStream_Write(substream, buff + 5, 6, NULL);




More information about the wine-cvs mailing list