Sven Baars : winex11.drv: Fix a memory leak (Coverity).

Alexandre Julliard julliard at winehq.org
Wed Sep 11 16:27:53 CDT 2019


Module: wine
Branch: master
Commit: 6033b3a7fbc29bc911b0173499b288ce7f226a4a
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=6033b3a7fbc29bc911b0173499b288ce7f226a4a

Author: Sven Baars <sven.wine at gmail.com>
Date:   Fri Sep  6 22:24:11 2019 +0200

winex11.drv: Fix a memory leak (Coverity).

Signed-off-by: Sven Baars <sven.wine at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winex11.drv/clipboard.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/clipboard.c
index a37530fdbf..c51954f1bf 100644
--- a/dlls/winex11.drv/clipboard.c
+++ b/dlls/winex11.drv/clipboard.c
@@ -1849,13 +1849,12 @@ static BOOL request_selection_contents( Display *display, BOOL changed )
                last_size != size ||
                memcmp( last_data, data, size ));
 
-    if (!changed)
+    if (!changed || !OpenClipboard( clipboard_hwnd ))
     {
         HeapFree( GetProcessHeap(), 0, data );
         return FALSE;
     }
 
-    if (!OpenClipboard( clipboard_hwnd )) return FALSE;
     TRACE( "selection changed, importing\n" );
     EmptyClipboard();
     is_clipboard_owner = TRUE;




More information about the wine-cvs mailing list