Francois Gouget : testbot: Document where parameters get untainted.

Alexandre Julliard julliard at winehq.org
Fri Sep 13 13:02:36 CDT 2019


Module: tools
Branch: master
Commit: 7e94278bcdc46f9fbd61d6344efa6a80fc055caf
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=7e94278bcdc46f9fbd61d6344efa6a80fc055caf

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Fri Sep 13 03:06:38 2019 +0200

testbot: Document where parameters get untainted.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/bin/LibvirtTool.pl    | 4 ++--
 testbot/bin/build/WineTest.pl | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/bin/LibvirtTool.pl b/testbot/bin/LibvirtTool.pl
index e348834..46b2793 100755
--- a/testbot/bin/LibvirtTool.pl
+++ b/testbot/bin/LibvirtTool.pl
@@ -104,7 +104,7 @@ while (@ARGV)
   }
 }
 
-# Check parameters
+# Check and untaint parameters
 my $VM;
 if (!defined $Usage)
 {
@@ -120,7 +120,7 @@ if (!defined $Usage)
   }
   elsif ($VMKey =~ /^([a-zA-Z0-9_]+)$/)
   {
-    $VMKey = $1;
+    $VMKey = $1; # untaint
     $VM = CreateVMs()->GetItem($VMKey);
     if (!defined $VM)
     {
diff --git a/testbot/bin/build/WineTest.pl b/testbot/bin/build/WineTest.pl
index 4b9a4b9..37c20d1 100755
--- a/testbot/bin/build/WineTest.pl
+++ b/testbot/bin/build/WineTest.pl
@@ -329,7 +329,7 @@ if (!defined $Usage)
     }
     elsif ($BaseTag =~ m/^([\w_.\-]+)$/)
     {
-      $BaseTag = $1;
+      $BaseTag = $1; # untaint
     }
     else
     {




More information about the wine-cvs mailing list