Francois Gouget : testbot/web: Remove an unused variable in PageBase::Redirect().

Alexandre Julliard julliard at winehq.org
Thu Sep 19 10:29:14 CDT 2019


Module: tools
Branch: master
Commit: 0118a19c2273f34b586258ba2464f23611a77da3
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=0118a19c2273f34b586258ba2464f23611a77da3

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Sep 19 15:00:52 2019 +0200

testbot/web: Remove an unused variable in PageBase::Redirect().

The goal was probably to get the hostname through
$Server->server_hostname but $Server is an Apache2-specific object
while $ENV{"HTTP_HOST"} seems more generic and works fine.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/WineTestBot/CGI/PageBase.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/CGI/PageBase.pm b/testbot/lib/WineTestBot/CGI/PageBase.pm
index 0eac6b1..d1442c1 100644
--- a/testbot/lib/WineTestBot/CGI/PageBase.pm
+++ b/testbot/lib/WineTestBot/CGI/PageBase.pm
@@ -408,7 +408,6 @@ sub Redirect($$$)
       $URI =~ s=^(.*)/[^/]*$=$1/=;
       $Location = $URI . $Location;
     }
-    my $Server = $self->{Request}->server;
     $Location = $Protocol . "://" . $ENV{"HTTP_HOST"} . $Location;
   }
   $self->{Request}->headers_out->set("Location", $Location);




More information about the wine-cvs mailing list