Francois Gouget : testbot/WineRunReconfig: Notify the administrator if recreating the snapshot failed.

Alexandre Julliard julliard at winehq.org
Tue Sep 24 11:41:03 CDT 2019


Module: tools
Branch: master
Commit: 51503c04fea1dd065f35b921b9a3e19dc0cd3d20
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=51503c04fea1dd065f35b921b9a3e19dc0cd3d20

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Sep 24 11:01:12 2019 +0200

testbot/WineRunReconfig: Notify the administrator if recreating the snapshot failed.

It's possible that the connection to the hypervisor was lost right when
the snapshot was being recreated. The TestBot may also be able to
recreate the snapshot from the powered off base snapshot. But such
failures are rare enough to warrant an investigation.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/bin/WineRunReconfig.pl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/testbot/bin/WineRunReconfig.pl b/testbot/bin/WineRunReconfig.pl
index 063bab2..bfbc5ab 100755
--- a/testbot/bin/WineRunReconfig.pl
+++ b/testbot/bin/WineRunReconfig.pl
@@ -518,6 +518,11 @@ if ($NewStatus eq 'completed')
     # Without the snapshot the VM is not usable anymore but FatalError() will
     # just mark it as 'dirty'. It's only the next time it is used that the
     # problem will be noticed and that it will be taken offline.
+    NotifyAdministrator("The ". $VM->Name ." update failed",
+                        "Could not recreate the $IdleSnapshot snapshot:\n\n".
+                        "$ErrMessage\n\n".
+                        "See the link below for more details:\n".
+                        MakeSecureURL(GetTaskURL($JobId, $StepNo, $TaskNo)) ."\n");
     FatalError("Could not recreate the $IdleSnapshot snapshot: $ErrMessage\n");
   }
 




More information about the wine-cvs mailing list