Sven Baars : setupapi: Fix a leak on early return in SetupDiGetDriverInfoDetailA (Valgrind).

Alexandre Julliard julliard at winehq.org
Fri Apr 17 16:12:59 CDT 2020


Module: wine
Branch: master
Commit: c85b14053155734c65631ccf3f838ed148ef93a9
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=c85b14053155734c65631ccf3f838ed148ef93a9

Author: Sven Baars <sbaars at codeweavers.com>
Date:   Fri Apr 17 20:20:10 2020 +0200

setupapi: Fix a leak on early return in SetupDiGetDriverInfoDetailA (Valgrind).

Signed-off-by: Sven Baars <sbaars at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/setupapi/devinst.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
index 11fd4d50e2..ccbc82bb76 100644
--- a/dlls/setupapi/devinst.c
+++ b/dlls/setupapi/devinst.c
@@ -4887,7 +4887,10 @@ BOOL WINAPI SetupDiGetDriverInfoDetailA(HDEVINFO devinfo, SP_DEVINFO_DATA *devic
     if (ret_size)
         *ret_size = size_needed;
     if (!detail_data)
+    {
+        SetupCloseInfFile(hinf);
         return TRUE;
+    }
 
     detail_data->CompatIDsLength = detail_data->CompatIDsOffset = 0;
     detail_data->HardwareID[0] = 0;




More information about the wine-cvs mailing list