Jacek Caban : appwiz.cpl: Explicitly compare strcmp result to 0.

Alexandre Julliard julliard at winehq.org
Mon Apr 20 15:48:20 CDT 2020


Module: wine
Branch: master
Commit: a2b08874cc2fc805558d416c3499d7cbe36a2170
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=a2b08874cc2fc805558d416c3499d7cbe36a2170

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Mon Apr 20 14:40:11 2020 +0200

appwiz.cpl: Explicitly compare strcmp result to 0.

Fixes clang warning:
addons.c:318:29: warning: use of logical '&&' with constant operand
[-Wconstant-logical-operand]

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/appwiz.cpl/addons.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c
index c1405d5ec8..d73b72a773 100644
--- a/dlls/appwiz.cpl/addons.c
+++ b/dlls/appwiz.cpl/addons.c
@@ -321,7 +321,7 @@ static enum install_res install_from_default_dir(void)
 
     if (ret == INSTALL_NEXT)
         ret = install_from_unix_file(INSTALL_DATADIR "/wine/", addon->subdir_name, addon->file_name);
-    if (ret == INSTALL_NEXT && strcmp(INSTALL_DATADIR, "/usr/share"))
+    if (ret == INSTALL_NEXT && strcmp(INSTALL_DATADIR, "/usr/share") != 0)
         ret = install_from_unix_file("/usr/share/wine/", addon->subdir_name, addon->file_name);
     if (ret == INSTALL_NEXT)
         ret = install_from_unix_file("/opt/wine/", addon->subdir_name, addon->file_name);




More information about the wine-cvs mailing list